Bug 887244 - Style list view dividers in new about:home as per design (r=sriram)

This commit is contained in:
Lucas Rocha 2013-07-09 20:35:24 +01:00
parent fd284e1c89
commit 6b0a5730b1
5 changed files with 11 additions and 1 deletions

View File

@ -5,6 +5,7 @@
package org.mozilla.gecko.home; package org.mozilla.gecko.home;
import org.mozilla.gecko.R;
import org.mozilla.gecko.db.BrowserContract.Bookmarks; import org.mozilla.gecko.db.BrowserContract.Bookmarks;
import org.mozilla.gecko.db.BrowserContract.Combined; import org.mozilla.gecko.db.BrowserContract.Combined;
import org.mozilla.gecko.db.BrowserDB.URLColumns; import org.mozilla.gecko.db.BrowserDB.URLColumns;
@ -39,7 +40,7 @@ public class HomeListView extends ListView
} }
public HomeListView(Context context, AttributeSet attrs) { public HomeListView(Context context, AttributeSet attrs) {
this(context, attrs, android.R.attr.listViewStyle); this(context, attrs, R.attr.homeListViewStyle);
} }
public HomeListView(Context context, AttributeSet attrs, int defStyle) { public HomeListView(Context context, AttributeSet attrs, int defStyle) {

View File

@ -45,6 +45,7 @@
<item name="bookmarkThumbnailViewStyle">@style/Widget.BookmarkThumbnailView</item> <item name="bookmarkThumbnailViewStyle">@style/Widget.BookmarkThumbnailView</item>
<item name="topBookmarkItemViewStyle">@style/Widget.TopBookmarkItemView</item> <item name="topBookmarkItemViewStyle">@style/Widget.TopBookmarkItemView</item>
<item name="topBookmarksViewStyle">@style/Widget.TopBookmarksView</item> <item name="topBookmarksViewStyle">@style/Widget.TopBookmarksView</item>
<item name="homeListViewStyle">@style/Widget.HomeListView</item>
</style> </style>
</resources> </resources>

View File

@ -26,6 +26,9 @@
<!-- Default style for the TopBookmarksView --> <!-- Default style for the TopBookmarksView -->
<attr name="topBookmarksViewStyle" format="reference" /> <attr name="topBookmarksViewStyle" format="reference" />
<!-- Default style for the HomeListView -->
<attr name="homeListViewStyle" format="reference" />
</declare-styleable> </declare-styleable>
<declare-styleable name="AboutHomeSection"> <declare-styleable name="AboutHomeSection">

View File

@ -148,6 +148,10 @@
<item name="android:gravity">left</item> <item name="android:gravity">left</item>
</style> </style>
<style name="Widget.HomeListView" parent="Widget.ListView">
<item name="android:divider">#E7ECF0</item>
</style>
<!-- <!--
TextAppearance TextAppearance
Note: Gecko uses light theme as default, while Android uses dark. Note: Gecko uses light theme as default, while Android uses dark.

View File

@ -80,6 +80,7 @@
<item name="bookmarkThumbnailViewStyle">@style/Widget.BookmarkThumbnailView</item> <item name="bookmarkThumbnailViewStyle">@style/Widget.BookmarkThumbnailView</item>
<item name="topBookmarkItemViewStyle">@style/Widget.TopBookmarkItemView</item> <item name="topBookmarkItemViewStyle">@style/Widget.TopBookmarkItemView</item>
<item name="topBookmarksViewStyle">@style/Widget.TopBookmarksView</item> <item name="topBookmarksViewStyle">@style/Widget.TopBookmarksView</item>
<item name="homeListViewStyle">@style/Widget.HomeListView</item>
</style> </style>
<style name="Gecko.Preferences" parent="GeckoPreferencesBase"/> <style name="Gecko.Preferences" parent="GeckoPreferencesBase"/>