wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 513185. Calculate an opaque backstop color for a dropdown combobox (select) before possible scroll (which leads to painting). r=roc

Browse Source 
--HG--
extra : rebase_source : 0ad5b14f24291dd16779328b1901a7f1a0091840
This commit is contained in:
Timothy Nikkel 2009-09-02 14:46:47 +12:00
parent 78880afb40
commit 69ef486736
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
layout/forms/nsListControlFrame.cpp
View File

@ -234,6 +234,8 @@ nsListControlFrame::BuildDisplayList(nsDisplayListBuilder* aBuilder,
DO_GLOBAL_REFLOW_COUNT_DSP("nsListControlFrame");
if (IsInDropDownMode()) {
NS_ASSERTION(NS_GET_A(mLastDropdownBackstopColor) == 255,
"need an opaque backstop color");
// XXX Because we have an opaque widget and we get called to paint with
// this frame as the root of a stacking context we need make sure to draw
// some opaque color over the whole widget. (Bug 511323)
@ -1175,6 +1177,8 @@ nsListControlFrame::Init(nsIContent* aContent,
mStartSelectionIndex = kNothingSelected;
mEndSelectionIndex = kNothingSelected;
mLastDropdownBackstopColor = PresContext()->DefaultBackgroundColor();
return result;
}
@ -1744,14 +1748,6 @@ nsListControlFrame::AboutToDropDown()
NS_ASSERTION(IsInDropDownMode(),
"AboutToDropDown called without being in dropdown mode");
if (mIsAllContentHere && mIsAllFramesHere && mHasBeenInitialized) {
ScrollToIndex(GetSelectedIndex());
#ifdef ACCESSIBILITY
FireMenuItemActiveEvent(); // Inform assistive tech what got focus
#endif
}
mItemSelectionStarted = PR_FALSE;
// Our widget doesn't get invalidated on changes to the rest of the document,
// so compute and store this color at the start of a dropdown so we don't
// get weird painting behaviour.
@ -1773,6 +1769,14 @@ nsListControlFrame::AboutToDropDown()
mLastDropdownBackstopColor =
NS_ComposeColors(PresContext()->DefaultBackgroundColor(),
mLastDropdownBackstopColor);
if (mIsAllContentHere && mIsAllFramesHere && mHasBeenInitialized) {
ScrollToIndex(GetSelectedIndex());
#ifdef ACCESSIBILITY
FireMenuItemActiveEvent(); // Inform assistive tech what got focus
#endif
}
mItemSelectionStarted = PR_FALSE;
}
// We are about to be rolledup from the outside (ComboboxFrame)