But 573290 - Intermittent (and not so intermittent with bug 568691!) failure in test_crashreporter_crash.js: the minidump callback is calling open(), which enters the dynamic loader and trashes memory, specifically the .extra file data. r=ted

This commit is contained in:
Benjamin Smedberg 2010-06-29 13:19:09 -04:00
parent b83c7495d6
commit 681cd4f679

View File

@ -529,6 +529,16 @@ nsresult SetExceptionHandler(nsILocalFile* aXREDirectory,
#error "Implement this for your platform"
#endif
#ifdef XP_UNIX
// During a crash we must not enter the dynamic loader for symbol
// resolution. The symbols used from within the exception handler
// which might not be called by the application during normal run
// should be early-resolved by calling them from here. See bug 573290.
int fd = open("/dev/null", O_RDONLY);
close(fd);
write(-1, NULL, 0);
#endif
// now set the exception handler
gExceptionHandler = new google_breakpad::
ExceptionHandler(tempPath.get(),