wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 505550 - Acquire the db's mutex when cloning statements in Connection::ExecuteAsync

Browse Source 
Hold the lock around all our API calls so we don't lose so much to the
background thread.
r=asuth
This commit is contained in:
Shawn Wilsher 2009-07-22 15:18:33 -07:00
parent 5a66fb8a7c
commit 6631ab6c3b
1 changed files with 38 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storage/src/mozStorageConnection.cpp
View File

@ -630,6 +630,8 @@ Connection::ExecuteAsync(mozIStorageStatement **aStatements,
{
int rc = SQLITE_OK;
nsTArray<StatementData> stmts(aNumStatements);
{
SQLiteMutexAutoLock lockedScope(mDBMutex);
for (PRUint32 i = 0; i < aNumStatements && rc == SQLITE_OK; i++) {
sqlite3_stmt *old_stmt =
static_cast<Statement *>(aStatements[i])->nativeStatement();
@ -665,7 +667,8 @@ Connection::ExecuteAsync(mozIStorageStatement **aStatements,
rc = SQLITE_NOMEM;
break;
}
}
} // for loop
} // locked Scope
// Dispatch to the background
nsresult rv = NS_OK;
@ -682,8 +685,11 @@ Connection::ExecuteAsync(mozIStorageStatement **aStatements,
}
// Always reset all the statements
{
SQLiteMutexAutoLock lockedScope(mDBMutex);
for (PRUint32 i = 0; i < aNumStatements; i++)
(void)aStatements[i]->Reset();
}
return rv;
}