mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
Bug 1210243
- ReadingListPanel.markAsRead can crash on a null return from getActivity() r=sebastian
This commit is contained in:
parent
aff57a8327
commit
640322a056
@ -78,6 +78,11 @@ public class ReadingListPanel extends HomeFragment {
|
||||
mList.setOnItemClickListener(new AdapterView.OnItemClickListener() {
|
||||
@Override
|
||||
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
|
||||
final Context context = getActivity();
|
||||
if (context == null) {
|
||||
return;
|
||||
}
|
||||
|
||||
final Cursor c = mAdapter.getCursor();
|
||||
if (c == null || !c.moveToPosition(position)) {
|
||||
return;
|
||||
@ -91,7 +96,7 @@ public class ReadingListPanel extends HomeFragment {
|
||||
// This item is a TwoLinePageRow, so we allow switch-to-tab.
|
||||
mUrlOpenListener.onUrlOpen(url, EnumSet.of(OnUrlOpenListener.Flags.ALLOW_SWITCH_TO_TAB));
|
||||
|
||||
markAsRead(id);
|
||||
markAsRead(context, id);
|
||||
}
|
||||
});
|
||||
|
||||
@ -110,9 +115,7 @@ public class ReadingListPanel extends HomeFragment {
|
||||
registerForContextMenu(mList);
|
||||
}
|
||||
|
||||
private void markAsRead(long id) {
|
||||
final Context context = getActivity();
|
||||
|
||||
private void markAsRead(final Context context, final long id) {
|
||||
GeckoProfile.get(context).getDB().getReadingListAccessor().markAsRead(
|
||||
context.getContentResolver(),
|
||||
id
|
||||
|
Loading…
Reference in New Issue
Block a user