From 636eec2f2a0a0414fdac584966c75a500ef2c544 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Thu, 6 Nov 2014 09:29:11 +0900 Subject: [PATCH] Bug 1094037 - Move EXTRA_COMPONENTS and EXTRA_PP_COMPONENTS to the misc tier. r=gps --- config/rules.mk | 6 ++++-- python/mozbuild/mozbuild/frontend/context.py | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/config/rules.mk b/config/rules.mk index 639327dc528..fc575768d8e 100644 --- a/config/rules.mk +++ b/config/rules.mk @@ -1184,10 +1184,11 @@ endif endif ifdef EXTRA_COMPONENTS -libs:: $(EXTRA_COMPONENTS) +misc:: $(EXTRA_COMPONENTS) ifndef NO_DIST_INSTALL EXTRA_COMPONENTS_FILES := $(EXTRA_COMPONENTS) EXTRA_COMPONENTS_DEST := $(FINAL_TARGET)/components +EXTRA_COMPONENTS_TARGET := misc INSTALL_TARGETS += EXTRA_COMPONENTS endif @@ -1196,13 +1197,14 @@ endif ifdef EXTRA_PP_COMPONENTS ifndef NO_DIST_INSTALL EXTRA_PP_COMPONENTS_PATH := $(FINAL_TARGET)/components +EXTRA_PP_COMPONENTS_TARGET := misc PP_TARGETS += EXTRA_PP_COMPONENTS endif endif EXTRA_MANIFESTS = $(filter %.manifest,$(EXTRA_COMPONENTS) $(EXTRA_PP_COMPONENTS)) ifneq (,$(EXTRA_MANIFESTS)) -libs:: $(call mkdir_deps,$(FINAL_TARGET)) +misc:: $(call mkdir_deps,$(FINAL_TARGET)) $(call py_action,buildlist,$(FINAL_TARGET)/chrome.manifest $(patsubst %,'manifest components/%',$(notdir $(EXTRA_MANIFESTS)))) endif diff --git a/python/mozbuild/mozbuild/frontend/context.py b/python/mozbuild/mozbuild/frontend/context.py index 1746c60a175..b5a390cd9d3 100644 --- a/python/mozbuild/mozbuild/frontend/context.py +++ b/python/mozbuild/mozbuild/frontend/context.py @@ -377,6 +377,8 @@ def ContextDerivedTypedList(type, base_class=List): # - 'export' # - 'libs': everything that is not built from C/C++/ObjC source and that has # traditionally been in the libs tier. +# - 'misc': like libs, but with parallel build. Eventually, everything that +# currently is in libs should move here. # A value of None means the variable has no direct effect on any tier. VARIABLES = { @@ -509,7 +511,7 @@ VARIABLES = { This variable contains a list of files to copy into ``$(FINAL_TARGET)/components/``. - """, 'libs'), + """, 'misc'), 'EXTRA_JS_MODULES': (HierarchicalStringList, list, """Additional JavaScript files to distribute. @@ -542,7 +544,7 @@ VARIABLES = { This variable contains a list of files to preprocess. Generated files will be installed in the ``/components`` directory of the distribution. - """, 'libs'), + """, 'misc'), 'FINAL_LIBRARY': (unicode, unicode, """Library in which the objects of the current directory will be linked.