wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

bug 893968 - LaunchState locking isn't actually locking anything useful r=kats

Browse Source
This commit is contained in:
Brad Lassey 2013-07-15 15:36:00 -04:00
parent b8afdbdee5
commit 626ccd359e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mobile/android/base/GeckoThread.java
View File

@ -120,6 +120,8 @@ public class GeckoThread extends Thread implements GeckoEventListener {
GeckoAppShell.runGecko(path, args, mUri, type);
}
private static Object sLock = new Object();
@Override
public void handleMessage(String event, JSONObject message) {
if ("Gecko:Ready".equals(event)) {
@ -130,13 +132,13 @@ public class GeckoThread extends Thread implements GeckoEventListener {
}
public static boolean checkLaunchState(LaunchState checkState) {
synchronized (sLaunchState) {
synchronized (sLock) {
return sLaunchState == checkState;
}
}
static void setLaunchState(LaunchState setState) {
synchronized (sLaunchState) {
synchronized (sLock) {
sLaunchState = setState;
}
}
@ -146,7 +148,7 @@ public class GeckoThread extends Thread implements GeckoEventListener {
* state is <code>checkState</code>; otherwise do nothing and return false.
*/
static boolean checkAndSetLaunchState(LaunchState checkState, LaunchState setState) {
synchronized (sLaunchState) {
synchronized (sLock) {
if (sLaunchState != checkState)
return false;
sLaunchState = setState;