diff --git a/build/upload.py b/build/upload.py index 7c26b2bad43..cf77aab852e 100644 --- a/build/upload.py +++ b/build/upload.py @@ -129,6 +129,10 @@ def GetBaseRelativePath(path, local_file, base_path): full remote path to place the file in. If base_path is not None, include the relative path from base_path to file.""" if base_path is None or not local_file.startswith(base_path): + # Hack to work around OSX uploading the i386 SDK from i386/dist. Both + # the i386 SDK and x86-64 SDK end up in the same directory this way. + if base_path.endswith('/x86_64/dist'): + return GetBaseRelativePath(path, local_file, base_path.replace('/x86_64/', '/i386/')) return path dir = os.path.dirname(local_file) # strip base_path + extra slash and make it unixy diff --git a/toolkit/mozapps/installer/package-name.mk b/toolkit/mozapps/installer/package-name.mk index 04d0b3a7c9c..665b0f8d9ec 100644 --- a/toolkit/mozapps/installer/package-name.mk +++ b/toolkit/mozapps/installer/package-name.mk @@ -60,6 +60,7 @@ else PKG_BASENAME = $(MOZ_PKG_APPNAME)-$(MOZ_PKG_VERSION).$(AB_CD).$(MOZ_PKG_PLATFORM) endif PKG_PATH = +SDK_PATH = PKG_INST_BASENAME = $(PKG_BASENAME).installer PKG_STUB_BASENAME = $(PKG_BASENAME).installer-stub PKG_INST_PATH = install/sea/ @@ -102,14 +103,9 @@ PKG_INST_BASENAME = $(MOZ_PKG_APPNAME_LC)-setup-$(MOZ_PKG_VERSION) endif endif PKG_PATH = $(MOZ_PKG_PLATFORM)/$(AB_CD)/ +SDK_PATH = $(PKG_PATH)/sdk/ CHECKSUMS_FILE_BASENAME = $(MOZ_PKG_APPNAME_LC)-$(MOZ_PKG_VERSION) MOZ_INFO_BASENAME = $(MOZ_PKG_APPNAME_LC)-$(MOZ_PKG_VERSION) -ifeq ($(MOZ_APP_NAME),xulrunner) -PKG_PATH = runtimes/ -PKG_BASENAME = $(MOZ_APP_NAME)-$(MOZ_PKG_VERSION).$(AB_CD).$(MOZ_PKG_PLATFORM) -CHECKSUMS_FILE_BASENAME = $(PKG_BASENAME) -MOZ_INFO_BASENAME = $(PKG_BASENAME) -endif PKG_INST_PATH = $(PKG_PATH) PKG_UPDATE_BASENAME = $(MOZ_PKG_APPNAME_LC)-$(MOZ_PKG_VERSION) PKG_UPDATE_PATH = update/$(PKG_PATH) diff --git a/toolkit/mozapps/installer/upload-files.mk b/toolkit/mozapps/installer/upload-files.mk index b992ddfc357..859c605c93c 100644 --- a/toolkit/mozapps/installer/upload-files.mk +++ b/toolkit/mozapps/installer/upload-files.mk @@ -51,12 +51,6 @@ PACKAGE = $(PKG_PATH)$(PKG_BASENAME)$(PKG_SUFFIX) # By default, the SDK uses the same packaging type as the main bundle, # but on mac it is a .tar.bz2 -SDK_PATH = $(PKG_PATH) -ifeq ($(MOZ_APP_NAME),xulrunner) -SDK_PATH = sdk/ -# Don't codesign xulrunner internally -MOZ_INTERNAL_SIGNING_FORMAT = -endif SDK_SUFFIX = $(PKG_SUFFIX) SDK = $(SDK_PATH)$(PKG_BASENAME).sdk$(SDK_SUFFIX) ifdef UNIVERSAL_BINARY @@ -122,13 +116,13 @@ ifeq ($(MOZ_PKG_FORMAT),TAR) PKG_SUFFIX = .tar INNER_MAKE_PACKAGE = $(CREATE_FINAL_TAR) - $(MOZ_PKG_DIR) > $(PACKAGE) INNER_UNMAKE_PACKAGE = $(UNPACK_TAR) < $(UNPACKAGE) -MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk > $(SDK) +MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk > '$(SDK)' endif ifeq ($(MOZ_PKG_FORMAT),TGZ) PKG_SUFFIX = .tar.gz INNER_MAKE_PACKAGE = $(CREATE_FINAL_TAR) - $(MOZ_PKG_DIR) | gzip -vf9 > $(PACKAGE) INNER_UNMAKE_PACKAGE = gunzip -c $(UNPACKAGE) | $(UNPACK_TAR) -MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | gzip -vf9 > $(SDK) +MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | gzip -vf9 > '$(SDK)' endif ifeq ($(MOZ_PKG_FORMAT),BZ2) PKG_SUFFIX = .tar.bz2 @@ -138,7 +132,7 @@ else INNER_MAKE_PACKAGE = $(CREATE_FINAL_TAR) - $(MOZ_PKG_DIR) | bzip2 -vf > $(PACKAGE) endif INNER_UNMAKE_PACKAGE = bunzip2 -c $(UNPACKAGE) | $(UNPACK_TAR) -MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | bzip2 -vf > $(SDK) +MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | bzip2 -vf > '$(SDK)' endif ifeq ($(MOZ_PKG_FORMAT),ZIP) ifdef MOZ_EXTERNAL_SIGNING_FORMAT @@ -149,7 +143,7 @@ PKG_SUFFIX = .zip INNER_MAKE_PACKAGE = $(ZIP) -r9D $(PACKAGE) $(MOZ_PKG_DIR) \ -x \*/.mkdir.done INNER_UNMAKE_PACKAGE = $(UNZIP) $(UNPACKAGE) -MAKE_SDK = $(call py_action,zip,$(SDK) $(MOZ_APP_NAME)-sdk) +MAKE_SDK = $(call py_action,zip,'$(SDK)' $(MOZ_APP_NAME)-sdk) endif ifeq ($(MOZ_PKG_FORMAT),SFX7Z) PKG_SUFFIX = .exe @@ -572,11 +566,7 @@ INNER_UNMAKE_PACKAGE = \ # The plst and blkx resources are skipped because they belong to each # individual dmg and are created by hdiutil. SDK_SUFFIX = .tar.bz2 -SDK = $(MOZ_PKG_APPNAME)-$(MOZ_PKG_VERSION).$(AB_CD).mac-$(TARGET_CPU).sdk$(SDK_SUFFIX) -ifeq ($(MOZ_APP_NAME),xulrunner) -SDK = $(SDK_PATH)$(MOZ_APP_NAME)-$(MOZ_PKG_VERSION).$(AB_CD).mac-$(TARGET_CPU).sdk$(SDK_SUFFIX) -endif -MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | bzip2 -vf > $(SDK) +MAKE_SDK = $(CREATE_FINAL_TAR) - $(MOZ_APP_NAME)-sdk | bzip2 -vf > '$(SDK)' endif ifdef MOZ_INTERNAL_SIGNING_FORMAT @@ -612,8 +602,7 @@ MAKE_PACKAGE += && $(MOZ_SIGN_PACKAGE_CMD) '$(PACKAGE)' endif ifdef MOZ_SIGN_CMD -MAKE_SDK += && $(MOZ_SIGN_CMD) -f gpg $(SDK) -UPLOAD_EXTRA_FILES += $(SDK).asc +MAKE_SDK += && $(MOZ_SIGN_CMD) -f gpg '$(SDK)' endif NO_PKG_FILES += \ @@ -773,6 +762,7 @@ UPLOAD_FILES= \ $(call QUOTED_WILDCARD,$(DIST)/$(PKG_PATH)$(GTEST_PACKAGE)) \ $(call QUOTED_WILDCARD,$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip) \ $(call QUOTED_WILDCARD,$(DIST)/$(SDK)) \ + $(call QUOTED_WILDCARD,$(DIST)/$(SDK).asc) \ $(call QUOTED_WILDCARD,$(MOZ_SOURCESTAMP_FILE)) \ $(call QUOTED_WILDCARD,$(MOZ_BUILDINFO_FILE)) \ $(call QUOTED_WILDCARD,$(MOZ_MOZINFO_FILE)) \ @@ -793,8 +783,8 @@ endif ifdef UNIFY_DIST UNIFY_ARCH := $(notdir $(patsubst %/,%,$(dir $(UNIFY_DIST)))) UPLOAD_FILES += \ - $(wildcard $(UNIFY_DIST)/$(SDK_PATH)$(PKG_BASENAME)-$(UNIFY_ARCH).sdk$(SDK_SUFFIX)) \ - $(wildcard $(UNIFY_DIST)/$(SDK_PATH)$(PKG_BASENAME)-$(UNIFY_ARCH).sdk$(SDK_SUFFIX).asc) + $(call QUOTED_WILDCARD,$(UNIFY_DIST)/$(SDK_PATH)$(PKG_BASENAME)-$(UNIFY_ARCH).sdk$(SDK_SUFFIX)) \ + $(call QUOTED_WILDCARD,$(UNIFY_DIST)/$(SDK_PATH)$(PKG_BASENAME)-$(UNIFY_ARCH).sdk$(SDK_SUFFIX).asc) endif SIGN_CHECKSUM_CMD=