wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1236548 - Allow JS_UNINITIALIZED_LEXICAL in jit::InvokeFunction. (r=Waldo)

Browse Source
This commit is contained in:
Eric Faust 2016-01-11 16:58:07 -08:00
parent 3fb50046bc
commit 5f688653e3
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/src/jit-test/tests/basic/invokeFunctionMagic.js Normal file
View File

@ -0,0 +1,14 @@
// JS_IS_CONSTRUCTING
var g = newGlobal();
do {
new g.String(); // jit::CreateThis passes JS_IS_CONSTRUCTING
} while (!inIon());
// JS_UNINITIALIZED_LEXICAL
class B {};
class D extends B {
constructor() { super(); }
};
do {
new D(); // jit::CreateThis passes JS_UNINITIALIZED_LEXICAL
} while (!inIon());

9
js/src/jit/VMFunctions.cpp
View File

@ -77,9 +77,14 @@ InvokeFunction(JSContext* cx, HandleObject obj, bool constructing, uint32_t argc
RootedValue newTarget(cx, argvWithoutThis[argc]);
// If |this| hasn't been created, we can use normal construction code.
if (thisv.isMagic(JS_IS_CONSTRUCTING))
// If |this| hasn't been created, or is JS_UNINITIALIED_LEXICAL,
// we can use normal construction code without creating an extraneous
// object.
if (thisv.isMagic()) {
MOZ_ASSERT(thisv.whyMagic() == JS_IS_CONSTRUCTING ||
thisv.whyMagic() == JS_UNINITIALIZED_LEXICAL);
return Construct(cx, fval, cargs, newTarget, rval);
}
// Otherwise the default |this| has already been created. We could
// almost perform a *call* at this point, but we'd break |new.target|