wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1153244 - increase JS helper threads stack space when MOZ_TSAN is enabled; r=bhackett

Browse Source 
TSan enforces a minimum stack size that's just slightly larger than our
default helper stack size.  It does this to store blobs of TSan-specific
data on each thread's stack.  Unfortunately, that means that even though
we'll actually receive a larger stack than we requested, the effective
usable space of that stack is significantly less than what we expect.
To offset TSan stealing our stack space from underneath us, increase the
default when we're running with MOZ_TSAN.
This commit is contained in:
Nathan Froyd 2015-04-10 09:27:20 -04:00
parent c9e5bf3544
commit 5c3d933f96
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
js/src/vm/HelperThreads.cpp
View File

@ -434,8 +434,26 @@ js::EnqueuePendingParseTasksAfterGC(JSRuntime* rt)
HelperThreadState().notifyAll(GlobalHelperThreadState::PRODUCER);
}
static const uint32_t HELPER_STACK_SIZE = 512 * 1024;
static const uint32_t HELPER_STACK_QUOTA = 450 * 1024;
static const uint32_t kDefaultHelperStackSize = 512 * 1024;
static const uint32_t kDefaultHelperStackQuota = 450 * 1024;
// TSan enforces a minimum stack size that's just slightly larger than our
// default helper stack size. It does this to store blobs of TSan-specific
// data on each thread's stack. Unfortunately, that means that even though
// we'll actually receive a larger stack than we requested, the effective
// usable space of that stack is significantly less than what we expect.
// To offset TSan stealing our stack space from underneath us, double the
// default.
//
// Note that we don't need this for ASan/MOZ_ASAN because ASan doesn't
// require all the thread-specific state that TSan does.
#if defined(MOZ_TSAN)
static const uint32_t HELPER_STACK_SIZE = 2 * kDefaultHelperStackSize;
static const uint32_t HELPER_STACK_QUOTA = 2 * kDefaultHelperStackQuota;
#else
static const uint32_t HELPER_STACK_SIZE = kDefaultHelperStackSize;
static const uint32_t HELPER_STACK_QUOTA = kDefaultHelperStackQuota;
#endif
void
GlobalHelperThreadState::ensureInitialized()