From 5bea5771a21ef07055c85bc810690852a8a96273 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Wed, 2 Jan 2013 10:17:32 +0100 Subject: [PATCH] Bug 822584 - Run elfhack on packaged binaries instead of built binaries. r=ted --- Makefile.in | 7 ------- toolkit/mozapps/installer/packager.mk | 21 ++++++++++----------- 2 files changed, 10 insertions(+), 18 deletions(-) diff --git a/Makefile.in b/Makefile.in index d7898275d01..70fabb451db 100644 --- a/Makefile.in +++ b/Makefile.in @@ -150,13 +150,6 @@ SYMBOL_INDEX_NAME = \ buildsymbols: ifdef MOZ_CRASHREPORTER -ifdef USE_ELF_HACK - ifeq (mobile,$(MOZ_BUILD_APP)) - $(MAKE) -C mobile/xul/installer elfhack - else - $(MAKE) -C $(MOZ_BUILD_APP)/installer elfhack - endif -endif echo building symbol store $(RM) -r $(DIST)/crashreporter-symbols $(RM) "$(DIST)/$(SYMBOL_ARCHIVE_BASENAME).zip" diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk index 588a6156261..33240f7bf3b 100644 --- a/toolkit/mozapps/installer/packager.mk +++ b/toolkit/mozapps/installer/packager.mk @@ -745,17 +745,7 @@ ifdef MOZ_SIGN_PREPARED_PACKAGE_CMD $(MOZ_SIGN_PREPARED_PACKAGE_CMD) $(DEPTH)/installer-stage && true endif -elfhack: -ifdef USE_ELF_HACK - @echo === - @echo === If you get failures below, please file a bug describing the error - @echo === and your environment \(compiler and linker versions\), and use - @echo === --disable-elf-hack until this is fixed. - @echo === - cd $(DIST)/bin; find . -name "*$(DLL_SUFFIX)" | xargs ../../build/unix/elfhack/elfhack -endif - -stage-package: $(MOZ_PKG_MANIFEST) $(MOZ_PKG_REMOVALS_GEN) elfhack +stage-package: $(MOZ_PKG_MANIFEST) $(MOZ_PKG_REMOVALS_GEN) @rm -rf $(DIST)/$(PKG_PATH)$(PKG_BASENAME).tar $(DIST)/$(PKG_PATH)$(PKG_BASENAME).dmg $@ $(EXCLUDE_LIST) ifndef MOZ_FAST_PACKAGE @rm -rf $(DIST)/$(MOZ_PKG_DIR) @@ -843,6 +833,15 @@ ifndef PKG_SKIP_STRIP -exec $(STRIP) $(STRIP_FLAGS) {} >/dev/null 2>&1 \; endif endif # PKG_SKIP_STRIP +ifdef USE_ELF_HACK + @echo === + @echo === If you get failures below, please file a bug describing the error + @echo === and your environment \(compiler and linker versions\), and use + @echo === --disable-elf-hack until this is fixed. + @echo === + cd $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR); find . -name "*$(DLL_SUFFIX)" | xargs ../../build/unix/elfhack/elfhack +endif + # We always sign nss because we don't do it from security/manager anymore @$(SIGN_NSS) @echo "Removing unpackaged files..."