Bug 917885 - Minimize the #includes in xpcom/base; r=bsmedberg

xpcom/base/AvailableMemoryTracker.cpp

@@ -6,19 +6,19 @@
 
 #include "mozilla/AvailableMemoryTracker.h"
 
+#if defined(XP_WIN)
 #include "prinrval.h"
 #include "prenv.h"
-
 #include "nsIMemoryReporter.h"
+#include "nsMemoryPressure.h"
+#endif
+
 #include "nsIObserver.h"
 #include "nsIObserverService.h"
 #include "nsIRunnable.h"
 #include "nsISupports.h"
-#include "nsMemoryPressure.h"
-#include "nsPrintfCString.h"
-#include "nsThread.h"
+#include "nsThreadUtils.h"
 
-#include "mozilla/Atomics.h"
 #include "mozilla/Preferences.h"
 #include "mozilla/Services.h"
 

xpcom/base/CycleCollectedJSRuntime.h

@@ -9,7 +9,6 @@
 
 #include "mozilla/MemoryReporting.h"
 #include "jsapi.h"
-#include "js/Class.h"
 
 #include "nsCycleCollector.h"
 #include "nsCycleCollectionParticipant.h"
@@ -18,9 +17,12 @@
 #include "nsTArray.h"
 
 class nsCycleCollectionNoteRootCallback;
-class nsScriptObjectTracer;
 class nsIException;
 
+namespace js {
+class Class;
+}
+
 namespace mozilla {
 
 class JSGCThingParticipant: public nsCycleCollectionParticipant

xpcom/base/VisualEventTracer.cpp

@@ -8,7 +8,6 @@
 #include "nscore.h"
 #include "prthread.h"
 #include "prprf.h"
-#include "prio.h"
 #include "prenv.h"
 #include "plstr.h"
 #include "nsThreadUtils.h"

xpcom/base/VisualEventTracer.h

@@ -20,11 +20,12 @@
  * to record in the log.
  */
 
-#include "nscore.h"
+#include <stdint.h>
+#include "mozilla/Attributes.h"
 #include "mozilla/GuardObjects.h"
-#include "nsIVisualEventTracer.h"
 
 #ifdef MOZ_VISUAL_EVENT_TRACER
+#include "nsIVisualEventTracer.h"
 
 // Bind an object instance, usually |this|, to a name, usually URL or 
 // host name, the instance deals with for its lifetime.  The name string 

xpcom/base/nsConsoleMessage.cpp

@@ -8,7 +8,6 @@
  */
 
 #include "nsConsoleMessage.h"
-#include "nsReadableUtils.h"
 #include "jsapi.h"
 
 NS_IMPL_ISUPPORTS1(nsConsoleMessage, nsIConsoleMessage)

xpcom/base/nsConsoleService.cpp

@@ -11,14 +11,12 @@
 /* Threadsafe. */
 
 #include "nsMemory.h"
-#include "nsIServiceManager.h"
 #include "nsCOMArray.h"
 #include "nsThreadUtils.h"
 
 #include "nsConsoleService.h"
 #include "nsConsoleMessage.h"
 #include "nsIClassInfoImpl.h"
-#include "nsThreadUtils.h"
 
 #include "mozilla/Preferences.h"
 

xpcom/base/nsConsoleService.h

@@ -13,7 +13,6 @@
 #include "mozilla/Attributes.h"
 #include "mozilla/Mutex.h"
 
-#include "nsCOMPtr.h"
 #include "nsInterfaceHashtable.h"
 #include "nsHashKeys.h"
 

xpcom/base/nsCycleCollector.cpp

@@ -105,34 +105,25 @@
 #include "mozilla/CycleCollectedJSRuntime.h"
 #include "nsCycleCollectionParticipant.h"
 #include "nsCycleCollectionNoteRootCallback.h"
-#include "nsHashKeys.h"
 #include "nsDeque.h"
 #include "nsCycleCollector.h"
 #include "nsThreadUtils.h"
 #include "prenv.h"
-#include "prprf.h"
-#include "plstr.h"
 #include "nsPrintfCString.h"
 #include "nsTArray.h"
 #include "nsIConsoleService.h"
-#include "nsTArray.h"
 #include "mozilla/Attributes.h"
 #include "nsICycleCollectorListener.h"
 #include "nsIMemoryReporter.h"
 #include "nsIFile.h"
-#include "nsDirectoryServiceDefs.h"
 #include "nsMemoryInfoDumper.h"
 #include "xpcpublic.h"
-#include "nsXPCOMPrivate.h"
 #include "GeckoProfiler.h"
 #include <stdint.h>
 #include <stdio.h>
-#include <string.h>
 
-#include "mozilla/CondVar.h"
 #include "mozilla/Likely.h"
 #include "mozilla/mozPoisonWrite.h"
-#include "mozilla/Mutex.h"
 #include "mozilla/Telemetry.h"
 #include "mozilla/ThreadLocal.h"
 

xpcom/base/nsCycleCollector.h

@@ -8,7 +8,6 @@
 
 class nsICycleCollectorListener;
 class nsISupports;
-class nsScriptObjectTracer;
 
 #include "nsError.h"
 #include "nsID.h"

xpcom/base/nsDebugImpl.cpp

@@ -16,8 +16,6 @@
 #include "nsStringGlue.h"
 #include "prprf.h"
 #include "prlog.h"
-#include "prinit.h"
-#include "plstr.h"
 #include "nsError.h"
 #include "prerror.h"
 #include "prerr.h"
@@ -27,13 +25,12 @@
 #include <android/log.h>
 #endif
 
-#if defined(XP_UNIX) || defined(_WIN32) || defined(XP_OS2)
-/* for abort() and getenv() */
+#ifdef _WIN32
+/* for getenv() */
 #include <stdlib.h>
 #endif
 
 #include "nsTraceRefcntImpl.h"
-#include "nsISupportsUtils.h"
 
 #if defined(XP_UNIX)
 #include <signal.h>
@@ -49,7 +46,6 @@
 
 #if defined(XP_MACOSX)
 #include <stdbool.h>
-#include <sys/types.h>
 #include <unistd.h>
 #include <sys/sysctl.h>
 #endif

xpcom/base/nsErrorService.cpp

@@ -4,7 +4,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "nsErrorService.h"
-#include "nsCRT.h"
+#include "nsCRTGlue.h"
 #include "nsAutoPtr.h"
 
 static void*

xpcom/base/nsGZFileWriter.h

@@ -5,7 +5,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "nsIGZFileWriter.h"
-#include <stdio.h>
 #include "zlib.h"
 
 /**

xpcom/base/nsInterfaceRequestorAgg.cpp

@@ -3,6 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "nsInterfaceRequestorAgg.h"
+#include "nsIInterfaceRequestor.h"
 #include "nsCOMPtr.h"
 #include "mozilla/Attributes.h"
 #include "nsThreadUtils.h"

xpcom/base/nsInterfaceRequestorAgg.h

@@ -5,9 +5,10 @@
 #ifndef nsInterfaceRequestorAgg_h__
 #define nsInterfaceRequestorAgg_h__
 
-#include "nsIInterfaceRequestor.h"
+#include "nsError.h"
 
 class nsIEventTarget;
+class nsIInterfaceRequestor;
 
 /**
  * This function returns an instance of nsIInterfaceRequestor that aggregates

xpcom/base/nsMacUtilsImpl.cpp

@@ -6,7 +6,6 @@
 #include "nsMacUtilsImpl.h"
 
 #include <CoreFoundation/CoreFoundation.h>
-#include <sys/sysctl.h>
 
 NS_IMPL_ISUPPORTS1(nsMacUtilsImpl, nsIMacUtils)
 

xpcom/base/nsMemoryImpl.cpp

@@ -3,21 +3,14 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "nsXPCOM.h"
 #include "nsMemoryImpl.h"
 #include "nsThreadUtils.h"
 
 #include "nsIObserver.h"
 #include "nsIObserverService.h"
-#include "nsIServiceManager.h"
 #include "nsISimpleEnumerator.h"
 
-#include "prcvar.h"
-#include "pratom.h"
-
-#include "nsAlgorithm.h"
 #include "nsCOMPtr.h"
-#include "nsString.h"
 #include "mozilla/Services.h"
 
 #ifdef ANDROID

xpcom/base/nsMemoryImpl.h

@@ -10,7 +10,6 @@
 
 #include "nsIMemory.h"
 #include "nsIRunnable.h"
-#include "prtime.h"
 
 // nsMemoryImpl is a static object. We can do this because it doesn't have
 // a constructor/destructor or any instance members. Please don't add

xpcom/base/nsMemoryInfoDumper.cpp

@@ -6,11 +6,9 @@
 
 #include "mozilla/nsMemoryInfoDumper.h"
 
-#include "mozilla/Atomics.h"
-#include "mozilla/ClearOnShutdown.h"
-#include "mozilla/FileUtils.h"
+#ifdef XP_LINUX
 #include "mozilla/Preferences.h"
-#include "mozilla/StaticPtr.h"
+#endif
 #include "mozilla/unused.h"
 #include "mozilla/dom/ContentParent.h"
 #include "mozilla/dom/ContentChild.h"
@@ -21,7 +19,7 @@
 #include "nsGZFileWriter.h"
 #include "nsJSEnvironment.h"
 #include "nsPrintfCString.h"
-#include "pratom.h"
+#include <errno.h>
 
 #ifdef XP_WIN
 #include <process.h>

xpcom/base/nsMemoryInfoDumper.h

@@ -8,7 +8,8 @@
 #define mozilla_nsMemoryInfoDumper_h
 
 #include "nsIMemoryInfoDumper.h"
-#include "nsString.h"
+
+class nsACString;
 
 /**
  * This class facilitates dumping information about our memory usage to disk.

xpcom/base/nsMemoryReporterManager.cpp

@@ -8,18 +8,14 @@
 #include "nsAutoPtr.h"
 #include "nsCOMPtr.h"
 #include "nsCOMArray.h"
-#include "nsDirectoryServiceUtils.h"
 #include "nsServiceManagerUtils.h"
 #include "nsMemoryReporterManager.h"
-#include "nsArrayEnumerator.h"
 #include "nsISimpleEnumerator.h"
-#include "nsIFile.h"
-#include "nsIFileStreams.h"
-#include "nsPrintfCString.h"
 #include "nsThreadUtils.h"
 #include "nsIObserverService.h"
-#include "nsThread.h"
+#if defined(XP_LINUX)
 #include "nsMemoryInfoDumper.h"
+#endif
 #include "mozilla/Telemetry.h"
 #include "mozilla/Attributes.h"
 #include "mozilla/Services.h"
@@ -37,7 +33,6 @@ using namespace mozilla;
 
 #if defined(XP_LINUX)
 
-#include <unistd.h>
 static nsresult GetProcSelfStatmField(int aField, int64_t* aN)
 {
     // There are more than two fields, but we're only interested in the first
@@ -455,7 +450,6 @@ public:
 
 #ifdef XP_UNIX
 
-#include <sys/time.h>
 #include <sys/resource.h>
 
 #define HAVE_PAGE_FAULT_REPORTERS 1

xpcom/base/nsMemoryReporterManager.h

@@ -6,8 +6,6 @@
 
 #include "nsIMemoryReporter.h"
 #include "mozilla/Mutex.h"
-#include "mozilla/Attributes.h"
-#include "nsString.h"
 #include "nsTHashtable.h"
 #include "nsHashKeys.h"
 

xpcom/base/nsStackWalk.cpp

@@ -6,9 +6,8 @@
 
 /* API for getting a stack trace of the C/C++ stack on the current thread */
 
-#include "mozilla/Util.h"
 #include "mozilla/StackWalk.h"
-#include "nsDebug.h"
+#include "mozilla/Assertions.h"
 #include "nsStackWalkPrivate.h"
 
 #include "nsStackWalk.h"
@@ -42,7 +41,6 @@ static CriticalAddress gCriticalAddress;
 
 #if NSSTACKWALK_SUPPORTS_MACOSX
 #include <pthread.h>
-#include <errno.h>
 #include <CoreServices/CoreServices.h>
 
 typedef void
@@ -178,6 +176,7 @@ StackWalkInitCriticalAddress()
 #include <stdio.h>
 #include <malloc.h>
 #include "plstr.h"
+#include "mozilla/Util.h"
 
 #include "nspr.h"
 #include <imagehlp.h>
@@ -814,7 +813,6 @@ NS_FormatCodeAddressDetails(void *aPC, const nsCodeAddressDetails *aDetails,
 
 #include <stdlib.h>
 #include <string.h>
-#include <math.h>
 #include "nscore.h"
 #include <stdio.h>
 #include "plstr.h"
@@ -831,7 +829,6 @@ NS_FormatCodeAddressDetails(void *aPC, const nsCodeAddressDetails *aDetails,
 // Yes, this is a gcc only hack
 #if defined(MOZ_DEMANGLE_SYMBOLS)
 #include <cxxabi.h>
-#include <stdlib.h> // for free()
 #endif // MOZ_DEMANGLE_SYMBOLS
 
 void DemangleSymbol(const char * aSymbol, 

xpcom/base/nsSystemInfo.cpp

@@ -7,7 +7,7 @@
 
 #include "nsSystemInfo.h"
 #include "prsystem.h"
-#include "nsString.h"
+#include "prio.h"
 #include "prprf.h"
 #include "mozilla/SSE.h"
 #include "mozilla/arm.h"

xpcom/base/nsTraceRefcntImpl.cpp

@@ -9,12 +9,8 @@
 #include "nsISupports.h"
 #include "nsTArray.h"
 #include "prenv.h"
-#include "prprf.h"
-#include "prlog.h"
 #include "plstr.h"
 #include "prlink.h"
-#include <stdlib.h>
-#include "nsCOMPtr.h"
 #include "nsCRT.h"
 #include <math.h>
 #include "nsStackWalkPrivate.h"

xpcom/base/nsUUIDGenerator.cpp

@@ -13,8 +13,6 @@
 #include "prrng.h"
 #endif
 
-#include "nsMemory.h"
-
 #include "nsUUIDGenerator.h"
 
 using namespace mozilla;