wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 412600 - "for each over Arrays considered harmful" [p=tjduavis@gmail.com (Timothy Joseph Duavis) r=dietrich a1.9=beltzner]

Browse Source
This commit is contained in:
reed@reedloden.com 2008-01-25 00:23:10 -08:00
parent 6225fdee48
commit 5a2e6baba3
3 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
browser/components/places/content/editBookmarkOverlay.js
View File

@ -438,14 +438,14 @@ var gEditItemOverlay = {
if (tags.length > 0 || currentTags.length > 0) {
var tagsToRemove = [];
var tagsToAdd = [];
var t;
for each (t in currentTags) {
if (tags.indexOf(t) == -1)
tagsToRemove.push(t);
var i;
for (i = 0; i < currentTags.length; i++) {
if (tags.indexOf(currentTags[i]) == -1)
tagsToRemove.push(currentTags[i]);
}
for each (t in tags) {
if (currentTags.indexOf(t) == -1)
tagsToAdd.push(t);
for (i = 0; i < tags.length; i++) {
if (currentTags.indexOf(tags[i]) == -1)
tagsToAdd.push(tags[i]);
}
if (tagsToAdd.length > 0)
@ -682,7 +682,8 @@ var gEditItemOverlay = {
var tagsInField = this._getTagsArrayFromTagField();
var allTags = PlacesUtils.tagging.allTags;
for each (var tag in allTags) {
for (var i = 0; i < allTags.length; i++) {
var tag = allTags[i];
var elt = document.createElement("listitem");
elt.setAttribute("type", "checkbox");
elt.setAttribute("label", tag);

6
browser/components/places/content/treeView.js
View File

@ -375,7 +375,8 @@ PlacesTreeView.prototype = {
// restore selection
if (previouslySelectedNodes.length > 0) {
for each (var nodeInfo in previouslySelectedNodes) {
for (var i = 0; i < previouslySelectedNodes.length; i++) {
var nodeInfo = previouslySelectedNodes[i];
var index = nodeInfo.node.viewIndex;
// if the same node was used (happens on sorting-changes),
@ -780,7 +781,8 @@ PlacesTreeView.prototype = {
// restore selection
if (nodesToSelect.length > 0) {
for each (var node in nodesToSelect) {
for (var i = 0; i < nodesToSelect.length; i++) {
var node = nodesToSelect[i];
var index = node.viewIndex;
selection.rangedSelect(index, index, true);
}

6
browser/components/places/content/utils.js
View File

@ -1566,8 +1566,9 @@ var PlacesUtils = {
getMostRecentBookmarkForURI:
function PU_getMostRecentBookmarkForURI(aURI) {
var bmkIds = this.bookmarks.getBookmarkIdsForURI(aURI, {});
for each (var bk in bmkIds) {
for (var i = 0; i < bmkIds.length; i++) {
// Find the first folder which isn't a tag container
var bk = bmkIds[i];
var parent = this.bookmarks.getFolderIdForItem(bk);
if (parent == this.unfiledBookmarksFolderId)
return bk;
@ -1688,7 +1689,8 @@ var PlacesUtils = {
*/
_openTabset: function PU__openTabset(aItemsToOpen, aEvent) {
var urls = [];
for each (var item in aItemsToOpen) {
for (var i = 0; i < aItemsToOpen.length; i++) {
var item = aItemsToOpen[i];
if (item.isBookmark)
this.markPageAsFollowedBookmark(item.uri);
else