wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1000483: Remove unused isTrustAnchor parameter from CheckKeyUsage, r=cviecco

Browse Source 
--HG--
extra : rebase_source : 96e7b76362d6219193c814d35c332aae2ed5b48f
This commit is contained in:
Brian Smith 2014-04-23 13:38:19 -07:00
parent 522a852d9e
commit 5939fb33ef
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
security/pkix/lib/pkixcheck.cpp
View File

@ -42,15 +42,15 @@ CheckTimes(const CERTCertificate* cert, PRTime time)
// Modeled after GetKeyUsage in certdb.c
Result
CheckKeyUsage(EndEntityOrCA endEntityOrCA,
bool isTrustAnchor,
const SECItem* encodedKeyUsage,
KeyUsages requiredKeyUsagesIfPresent,
PLArenaPool* arena)
{
if (!encodedKeyUsage) {
// TODO: Reject certificates that are being used to verify certificate
// signatures unless the certificate is a trust anchor, to reduce the
// chances of an end-entity certificate being abused as a CA certificate.
// TODO(bug 970196): Reject certificates that are being used to verify
// certificate signatures unless the certificate is a trust anchor, to
// reduce the chances of an end-entity certificate being abused as a CA
// certificate.
// if (endEntityOrCA == MustBeCA && !isTrustAnchor) {
// return Fail(RecoverableError, SEC_ERROR_INADEQUATE_KEY_USAGE);
// }
@ -505,7 +505,7 @@ CheckIssuerIndependentProperties(TrustDomain& trustDomain,
// 4.2.1.2. Subject Key Identifier is ignored (see bug 965136).
// 4.2.1.3. Key Usage
rv = CheckKeyUsage(endEntityOrCA, isTrustAnchor, cert.encodedKeyUsage,
rv = CheckKeyUsage(endEntityOrCA, cert.encodedKeyUsage,
requiredKeyUsagesIfPresent, arena);
if (rv != Success) {
return rv;