Bug 1024801, part 2 - LookupCache::GetPrefixes should free arr even on failure. r=gcp

This commit is contained in:
Andrew McCreight 2014-06-26 09:29:06 -07:00
parent 8330301908
commit 58804d5c95

View File

@ -695,10 +695,13 @@ LookupCache::GetPrefixes(nsTArray<uint32_t>* aAddPrefixes)
uint32_t *arr;
nsresult rv = mPrefixSet->GetPrefixes(&cnt, &arr);
NS_ENSURE_SUCCESS(rv, rv);
if (!aAddPrefixes->AppendElements(arr, cnt))
return NS_ERROR_FAILURE;
bool appendOk = aAddPrefixes->AppendElements(arr, cnt);
nsMemory::Free(arr);
return NS_OK;
if (appendOk) {
return NS_OK;
} else {
return NS_ERROR_FAILURE;
}
}