From 583b9b45c6550d5cf58e336f4c57bf0ef83d6055 Mon Sep 17 00:00:00 2001 From: Chuck Lee Date: Mon, 9 Mar 2015 16:09:10 +0800 Subject: [PATCH] Bug 1140261 - Fix compiler error comparison of unsigned expression >= 0 is always true. r=hchang --- ipc/keystore/KeyStore.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/keystore/KeyStore.cpp b/ipc/keystore/KeyStore.cpp index b3b0f8df762..0371030526e 100644 --- a/ipc/keystore/KeyStore.cpp +++ b/ipc/keystore/KeyStore.cpp @@ -137,15 +137,15 @@ status_t BnKeystoreService::onTransact(uint32_t code, const Parcel& data, Parcel case SIGN: { CHECK_INTERFACE(IKeystoreService, data, reply); String16 name = data.readString16(); - size_t signDataSize = data.readInt32(); + ssize_t signDataSize = data.readInt32(); const uint8_t *signData = nullptr; - if (signDataSize >= 0 && signDataSize <= data.dataAvail()) { + if (signDataSize >= 0 && (size_t)signDataSize <= data.dataAvail()) { signData = (const uint8_t *)data.readInplace(signDataSize); } uint8_t *signResult = nullptr; size_t signResultSize; - int32_t ret = sign(name, signData, signDataSize, &signResult, + int32_t ret = sign(name, signData, (size_t)signDataSize, &signResult, &signResultSize); reply->writeNoException();