Bug 1158916 - Stop manually notifying MediaDecoder::mReadyStateWatchTarget. r=jww

If we've got our state graph set up properly, the watch target should be
notified automatically whenever anything relevant changes.
This commit is contained in:
Bobby Holley 2015-04-24 23:19:25 -07:00
parent 1aafd5f692
commit 57928a4913

View File

@ -1057,7 +1057,6 @@ void MediaDecoder::PlaybackEnded()
ChangeState(PLAY_STATE_ENDED);
InvalidateWithFlags(VideoFrameContainer::INVALIDATE_FORCE);
mReadyStateWatchTarget->Notify(); // XXXbholley - Still necessary?
if (mOwner) {
mOwner->PlaybackEnded();
}
@ -1251,7 +1250,6 @@ void MediaDecoder::OnSeekResolved(SeekResolveValue aVal)
PlaybackPositionChanged(aVal.mEventVisibility);
if (mOwner) {
mReadyStateWatchTarget->Notify(); // XXXbholley - Still necessary?
if (!seekWasAborted && (aVal.mEventVisibility != MediaDecoderEventVisibility::Suppressed)) {
mOwner->SeekCompleted();
if (fireEnded) {
@ -1268,7 +1266,6 @@ void MediaDecoder::SeekingStarted(MediaDecoderEventVisibility aEventVisibility)
return;
if (mOwner) {
mReadyStateWatchTarget->Notify(); // XXXbholley - Still necessary?
if (aEventVisibility != MediaDecoderEventVisibility::Suppressed) {
mOwner->SeekStarted();
}
@ -1651,7 +1648,6 @@ void MediaDecoder::NotifyDataArrived(const char* aBuffer, uint32_t aLength, int6
if (mDecoderStateMachine) {
mDecoderStateMachine->NotifyDataArrived(aBuffer, aLength, aOffset);
}
mReadyStateWatchTarget->Notify(); // XXXbholley - Still necessary?
}
// Provide access to the state machine object