wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

bug 528288 - require spdy compliant headers to be lower case and without chunked encodings r=honzab

Browse Source 
patch 5
This commit is contained in:
Patrick McManus 2011-12-02 10:28:57 -05:00
parent b2bd651739
commit 566e3aa844
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
netwerk/protocol/http/SpdySession.cpp
View File

@ -511,11 +511,37 @@ SpdySession::ConvertHeaders(nsDependentCSubstring &status,
PRUint16 valueLen = (nvpair[2 + nameLen] << 8) + nvpair[3 + nameLen];
if (lastHeaderByte < nvpair + 4 + nameLen + valueLen)
return NS_ERROR_ILLEGAL_VALUE;
// Look for upper case characters in the name. They are illegal.
for (char *cPtr = nameString.BeginWriting();
cPtr && cPtr < nameString.EndWriting();
++cPtr) {
if (*cPtr <= 'Z' && *cPtr >= 'A') {
nsCString toLog(nameString);
LOG(("SpdySession::ConvertHeaders session=%p stream=%p "
"upper case response header found. [%s]\n",
this, mFrameDataStream, toLog.get()));
return NS_ERROR_ILLEGAL_VALUE;
}
}
// HTTP Chunked responses are not legal over spdy. We do not need
// to look for chunked specifically because it is the only HTTP
// allowed default encoding and we did not negotiate further encodings
// via TE
if (nameString.Equals(NS_LITERAL_CSTRING("transfer-encoding"))) {
LOG(("SpdySession::ConvertHeaders session=%p stream=%p "
"transfer-encoding found. Chunked is invalid and no TE sent.",
this, mFrameDataStream));
return NS_ERROR_ILLEGAL_VALUE;
}
if (!nameString.Equals(NS_LITERAL_CSTRING("version")) &&
!nameString.Equals(NS_LITERAL_CSTRING("status")) &&
!nameString.Equals(NS_LITERAL_CSTRING("connection")) &&
!nameString.Equals(NS_LITERAL_CSTRING("transfer-encoding")) &&
!nameString.Equals(NS_LITERAL_CSTRING("keep-alive"))) {
nsDependentCSubstring valueString =
Substring (reinterpret_cast<const char *>(nvpair) + 4 + nameLen,

2
netwerk/protocol/http/SpdyStream.cpp
View File

@ -380,7 +380,7 @@ SpdyStream::ParseHttpRequestHeaders(const char *buf,
name.Equals("scheme") ||
name.Equals("keep-alive") ||
name.Equals("accept-encoding") ||
name.Equals("TE") ||
name.Equals("te") ||
name.Equals("connection") ||
name.Equals("proxy-connection") ||
name.Equals("url"))