Bug 883951: Fix bustage in browser_downloads.js test due to incorrect use of 'todo()' function. r=me

This commit is contained in:
Marina Samuel 2013-07-18 09:28:53 -04:00
parent 2c06f5ec0a
commit 5501fa1333

View File

@ -214,7 +214,7 @@ gTests.push({
desc: "zero downloads", desc: "zero downloads",
run: function () { run: function () {
yield resetDownloads(); yield resetDownloads();
todo("Test there are no visible notifications with an empty db."); todo(false, "Test there are no visible notifications with an empty db.");
} }
}); });
@ -247,12 +247,12 @@ gTests.push({
// we're going to add stuff to the downloads db. // we're going to add stuff to the downloads db.
yield spawn( gen_addDownloadRows( DownloadData ) ); yield spawn( gen_addDownloadRows( DownloadData ) );
todo("Check that Downloads._progressNotificationInfo and Downloads._downloadCount todo( false, "Check that Downloads._progressNotificationInfo and Downloads._downloadCount \
have the correct length (DownloadData.length) have the correct length (DownloadData.length) \
May also test that the correct notifications show up for various states."); May also test that the correct notifications show up for various states.");
todo("Iterate through download objects in Downloads._progressNotificationInfo todo(false, "Iterate through download objects in Downloads._progressNotificationInfo \
and confirm that the downloads they refer to are the same as those in and confirm that the downloads they refer to are the same as those in \
DownloadData."); DownloadData.");
} catch(e) { } catch(e) {
info("Show downloads, some error: " + e); info("Show downloads, some error: " + e);
@ -299,7 +299,7 @@ gTests.push({
is(downloadRows.length, 3, "Correct number of downloads in the db before removal"); is(downloadRows.length, 3, "Correct number of downloads in the db before removal");
todo("Get some download from Downloads._progressNotificationInfo, todo(false, "Get some download from Downloads._progressNotificationInfo, \
confirm that its file exists, then remove it."); confirm that its file exists, then remove it.");
// remove is async(?), wait a bit // remove is async(?), wait a bit
@ -318,7 +318,7 @@ gTests.push({
}); });
yield promisedDownloads; yield promisedDownloads;
todo("confirm that the removed download is no longer in the database todo(false, "confirm that the removed download is no longer in the database \
and its file no longer exists."); and its file no longer exists.");
} catch(e) { } catch(e) {