From 52cb29a93d27b00c765b81d3fe54f7ab7de12b71 Mon Sep 17 00:00:00 2001
From: Boris Zbarsky <bzbarsky@mit.edu>
Date: Thu, 22 Jan 2015 22:36:21 -0500
Subject: [PATCH] Bug 1121099.  Make <basefont> be an HTMLElement to match my
 reading of the spec and Chrome.  r=sicking

---
 parser/htmlparser/nsHTMLTagList.h                           | 2 +-
 testing/web-platform/meta/html/dom/interfaces.html.ini      | 6 ------
 .../web-platform/meta/html/semantics/interfaces.html.ini    | 3 ---
 testing/web-platform/tests/html/dom/interfaces.html         | 2 +-
 testing/web-platform/tests/html/semantics/interfaces.js     | 2 +-
 5 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/parser/htmlparser/nsHTMLTagList.h b/parser/htmlparser/nsHTMLTagList.h
index 88be0453126..26110979d31 100644
--- a/parser/htmlparser/nsHTMLTagList.h
+++ b/parser/htmlparser/nsHTMLTagList.h
@@ -46,7 +46,7 @@ HTML_HTMLELEMENT_TAG(aside)
 HTML_TAG(audio, Audio)
 HTML_HTMLELEMENT_TAG(b)
 HTML_TAG(base, Shared)
-HTML_TAG(basefont, Span)
+HTML_HTMLELEMENT_TAG(basefont)
 HTML_HTMLELEMENT_TAG(bdo)
 HTML_TAG(bgsound, Unknown)
 HTML_HTMLELEMENT_TAG(big)
diff --git a/testing/web-platform/meta/html/dom/interfaces.html.ini b/testing/web-platform/meta/html/dom/interfaces.html.ini
index 80207c2d49b..13574452fd8 100644
--- a/testing/web-platform/meta/html/dom/interfaces.html.ini
+++ b/testing/web-platform/meta/html/dom/interfaces.html.ini
@@ -744,12 +744,6 @@
   [Stringification of document.createElement("rb")]
     expected: FAIL
 
-  [HTMLUnknownElement must be primary interface of document.createElement("basefont")]
-    expected: FAIL
-
-  [Stringification of document.createElement("basefont")]
-    expected: FAIL
-
   [HTMLHtmlElement interface: existence and properties of interface object]
     expected: FAIL
 
diff --git a/testing/web-platform/meta/html/semantics/interfaces.html.ini b/testing/web-platform/meta/html/semantics/interfaces.html.ini
index edd654a6047..e02af87bfdc 100644
--- a/testing/web-platform/meta/html/semantics/interfaces.html.ini
+++ b/testing/web-platform/meta/html/semantics/interfaces.html.ini
@@ -1,8 +1,5 @@
 [interfaces.html]
   type: testharness
-  [Interfaces for basefont]
-    expected: FAIL
-
   [Interfaces for image]
     expected: FAIL
 
diff --git a/testing/web-platform/tests/html/dom/interfaces.html b/testing/web-platform/tests/html/dom/interfaces.html
index 80cb446ce15..c92782923cc 100644
--- a/testing/web-platform/tests/html/dom/interfaces.html
+++ b/testing/web-platform/tests/html/dom/interfaces.html
@@ -3239,6 +3239,7 @@ window.onload = function() {
 			'document.createElement("wbr")',
 			'document.createElement("summary")',
 			'document.createElement("acronym")',
+			'document.createElement("basefont")',
 		],
 		HTMLUnknownElement: [
 			'document.createElement("quasit")',
@@ -3248,7 +3249,6 @@ window.onload = function() {
 			'document.createElement("nextid")',
 			'document.createElement("rb")',
 			'document.createElement("spacer")',
-			'document.createElement("basefont")',
 			'document.createElement("directory")',
 			'document.createElement("mod")',
 		],
diff --git a/testing/web-platform/tests/html/semantics/interfaces.js b/testing/web-platform/tests/html/semantics/interfaces.js
index 5f5d2d908fa..8240607e466 100644
--- a/testing/web-platform/tests/html/semantics/interfaces.js
+++ b/testing/web-platform/tests/html/semantics/interfaces.js
@@ -6,7 +6,7 @@ var elements = [
   ["audio", "Audio"],
   ["b", ""],
   ["base", "Base"],
-  ["basefont", "Unknown"],
+  ["basefont", ""],
   ["bdo", ""],
   ["bgsound", "Unknown"],
   ["big", ""],