wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1187323 - Add some asserts to the assembler's linkJump/nextJump/setNextJump methods. r=nbp

Browse Source
This commit is contained in:
Jan de Mooij 2015-07-25 21:41:10 +02:00
parent 3507e2aa10
commit 4d61c75f16
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
js/src/jit/x86-shared/BaseAssembler-x86-shared.h
View File

@ -3824,6 +3824,13 @@ threeByteOpImmSimd("vblendps", VEX_PD, OP3_BLENDPS_VpsWpsIb, ESCAPE_3A, imm, off
// Linking & patching:
void assertValidJmpSrc(JmpSrc src)
{
// The target offset is stored at offset - 4.
MOZ_ASSERT(src.offset() > int32_t(sizeof(int32_t)));
MOZ_ASSERT(size_t(src.offset()) <= size());
}
bool nextJump(const JmpSrc& from, JmpSrc* next)
{
// Sanity check - if the assembler has OOM'd, it will start overwriting
@ -3831,10 +3838,14 @@ threeByteOpImmSimd("vblendps", VEX_PD, OP3_BLENDPS_VpsWpsIb, ESCAPE_3A, imm, off
if (oom())
return false;
assertValidJmpSrc(from);
const unsigned char* code = m_formatter.data();
int32_t offset = GetInt32(code + from.offset());
if (offset == -1)
return false;
MOZ_ASSERT(size_t(offset) < size());
*next = JmpSrc(offset);
return true;
}
@ -3845,6 +3856,9 @@ threeByteOpImmSimd("vblendps", VEX_PD, OP3_BLENDPS_VpsWpsIb, ESCAPE_3A, imm, off
if (oom())
return;
assertValidJmpSrc(from);
MOZ_ASSERT(to.offset() == -1 || size_t(to.offset()) <= size());
unsigned char* code = m_formatter.data();
SetInt32(code + from.offset(), to.offset());
}
@ -3859,6 +3873,9 @@ threeByteOpImmSimd("vblendps", VEX_PD, OP3_BLENDPS_VpsWpsIb, ESCAPE_3A, imm, off
if (oom())
return;
assertValidJmpSrc(from);
MOZ_ASSERT(size_t(to.offset()) <= size());
spew(".set .Lfrom%d, .Llabel%d", from.offset(), to.offset());
unsigned char* code = m_formatter.data();
SetRel32(code + from.offset(), code + to.offset());