wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 882547. Treat undefined values in WebIDL dictionaries as missing. r=smaug

Browse Source
This commit is contained in:
Boris Zbarsky 2013-06-17 13:07:03 -04:00
parent e1f8a8c273
commit 4a83c172fc
2 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
content/base/test/test_blobconstructor.html
View File

@ -33,7 +33,7 @@ is(blob.type, "null", "Blob type should be stringified");
blob = Blob([], {type: undefined});
ok(blob, "Blob should exist");
is(blob.type, "undefined", "Blob type should be stringified");
is(blob.type, "", "Blob type should be treated as missing");
try {
blob = Blob([]);

22
dom/bindings/Codegen.py
View File

@ -7718,7 +7718,6 @@ class CGDictionary(CGThing):
for m in self.memberInfo]
if memberInits:
body += (
"JSBool found;\n"
"JS::Rooted<JS::Value> temp(cx);\n"
"bool isNull = val.isNullOrUndefined();\n")
body += "\n\n".join(memberInits) + "\n"
@ -7900,48 +7899,35 @@ class CGDictionary(CGThing):
if conversionInfo.dealWithOptional:
replacements["declName"] = "(" + replacements["declName"] + ".Value())"
if member.defaultValue:
replacements["haveValue"] = "found"
replacements["haveValue"] = "!temp.isUndefined()"
# NOTE: jsids are per-runtime, so don't use them in workers
if self.workers:
propName = member.identifier.name
propCheck = ('JS_HasProperty(cx, &val.toObject(), "%s", &found)' %
propName)
propGet = ('JS_GetProperty(cx, &val.toObject(), "%s", temp.address())' %
propName)
else:
propId = self.makeIdName(member.identifier.name);
propCheck = ("JS_HasPropertyById(cx, &val.toObject(), %s, &found)" %
propId)
propGet = ("JS_GetPropertyById(cx, &val.toObject(), %s, temp.address())" %
propId)
conversionReplacements = {
"prop": self.makeMemberName(member.identifier.name),
"convert": string.Template(conversionInfo.template).substitute(replacements),
"propCheck": propCheck,
"propGet": propGet
}
conversion = ("if (isNull) {\n"
" found = false;\n"
"} else if (!${propCheck}) {\n"
" temp.setUndefined();\n"
"} else if (!${propGet}) {\n"
" return false;\n"
"}\n")
if member.defaultValue:
conversion += (
"if (found) {\n"
" if (!${propGet}) {\n"
" return false;\n"
" }\n"
"}\n"
"${convert}")
else:
conversion += (
"if (found) {\n"
"if (!temp.isUndefined()) {\n"
" ${prop}.Construct();\n"
" if (!${propGet}) {\n"
" return false;\n"
" }\n"
"${convert}\n"
"}")
conversionReplacements["convert"] = CGIndenter(