From 4880610010834c951357c03144b625379a913036 Mon Sep 17 00:00:00 2001 From: Robert Longson Date: Wed, 7 Aug 2013 17:59:08 +0100 Subject: [PATCH] Bug 898915 - Fix Axis() is not valid abort. r=dholbert --- content/svg/content/src/SVGLengthListSMILType.cpp | 6 ------ content/svg/content/src/crashtests/898915-1.svg | 5 +++++ content/svg/content/src/crashtests/crashtests.list | 1 + 3 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 content/svg/content/src/crashtests/898915-1.svg diff --git a/content/svg/content/src/SVGLengthListSMILType.cpp b/content/svg/content/src/SVGLengthListSMILType.cpp index 91a00231a44..586841829e3 100644 --- a/content/svg/content/src/SVGLengthListSMILType.cpp +++ b/content/svg/content/src/SVGLengthListSMILType.cpp @@ -93,12 +93,6 @@ SVGLengthListSMILType::Add(nsSMILValue& aDest, // should be, not zeros, and those values are not explicit or otherwise // available. - if (dest.IsEmpty() && valueToAdd.IsEmpty()) { - // Adding two identity values, no-op. This occurs when performing a - // discrete by-animation on an attribute with no specified base value. - return NS_OK; - } - if (!valueToAdd.Element()) { // Adding identity value - no-op NS_ABORT_IF_FALSE(valueToAdd.IsEmpty(), "Identity values should be empty"); diff --git a/content/svg/content/src/crashtests/898915-1.svg b/content/svg/content/src/crashtests/898915-1.svg new file mode 100644 index 00000000000..6e9b59c36ff --- /dev/null +++ b/content/svg/content/src/crashtests/898915-1.svg @@ -0,0 +1,5 @@ + + + + + diff --git a/content/svg/content/src/crashtests/crashtests.list b/content/svg/content/src/crashtests/crashtests.list index bbf1918e556..7b82e9593b0 100644 --- a/content/svg/content/src/crashtests/crashtests.list +++ b/content/svg/content/src/crashtests/crashtests.list @@ -71,3 +71,4 @@ load 880544-2.svg load 880544-3.svg load 880544-4.svg load 880544-5.svg +load 898915-1.svg