wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1074817 - Handle content preference downgrades for the timestamp column migration. r=MattN f=mak

Browse Source
This commit is contained in:
Tomasz Kołodziejski 2014-10-16 00:36:44 -07:00
parent ba19dca4a9
commit 485a5d5378
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
toolkit/components/contentprefs/nsContentPrefService.js
View File

@ -1167,6 +1167,13 @@ ContentPrefService.prototype = {
},
_dbMigrate: function ContentPrefService__dbMigrate(aDBConnection, aOldVersion, aNewVersion) {
/**
* Migrations should follow the template rules in bug 1074817 comment 3 which are:
* 1. Migration should be incremental and non-breaking.
* 2. It should be idempotent because one can downgrade an upgrade again.
* On downgrade:
* 1. Decrement schema version so that upgrade runs the migrations again.
*/
aDBConnection.beginTransaction();
try {
@ -1213,7 +1220,14 @@ ContentPrefService.prototype = {
},
_dbMigrate3To4: function ContentPrefService__dbMigrate3To4(aDBConnection) {
aDBConnection.executeSimpleSQL("ALTER TABLE prefs ADD COLUMN timestamp INTEGER NOT NULL DEFAULT 0");
// Add timestamp column if it does not exist yet. This operation is idempotent.
try {
let stmt = aDBConnection.createStatement("SELECT timestamp FROM prefs");
stmt.finalize();
} catch (e) {
aDBConnection.executeSimpleSQL("ALTER TABLE prefs ADD COLUMN timestamp INTEGER NOT NULL DEFAULT 0");
}
// To modify prefs_idx drop it and create again.
aDBConnection.executeSimpleSQL("DROP INDEX IF EXISTS prefs_idx");
this._dbCreateIndices(aDBConnection);