wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1091801 - fix inline assembly constraints; r=froydnj, a=Tomcat

Browse Source
This commit is contained in:
Steven Michaud 2014-10-29 08:47:18 -04:00
parent a25ec9463c
commit 465022173f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xpcom/base/CycleCollectedJSRuntime.cpp
View File

@ -1064,13 +1064,16 @@ CycleCollectedJSRuntime::DeferredFinalize(nsISupports* aSupports)
// We'll crash here if aSupports is poisoned (== 0x5a5a5a5a5a5a5a5a). This
// is better (more informative) than crashing in ReleaseSliceNow(). See
// bug 997908. This patch should get backed out when bug 997908 gets fixed,
// or if it doesn't actually help diagnose that bug.
// or if it doesn't actually help diagnose that bug. Specifying a constraint
// of "r" for aSupports ensures %0 is a register. Without this, clang
// sometimes mishandles this inline assembly code, causing crashes. See
// bug 1091801.
__asm__ __volatile__("push %%rax;"
"push %%rdx;"
"movq %0, %%rax;"
"movq (%%rax), %%rdx;"
"pop %%rdx;"
"pop %%rax;" : : "g" (aSupports));
"pop %%rax;" : : "r" (aSupports));
#endif
mDeferredSupports.AppendElement(aSupports);
}