wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1113980 - Try to fix a bug with [[Set]] and old proxies. r=Waldo

Browse Source
This commit is contained in:
Tom Schuster 2015-01-01 16:42:41 +01:00
parent 47e92f2b3c
commit 453e2241bb
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/src/jit-test/tests/basic/bug1113980.js Normal file
View File

@ -0,0 +1,10 @@
var p = Proxy.create({
getOwnPropertyDescriptor: function() {
return {value: 1, configurable: true, writable: true};
},
defineProperty: function() {
}
}, null);
var o = Object.create(p);
o.a = 1;

6
js/src/proxy/BaseProxyHandler.cpp
View File

@ -182,8 +182,10 @@ js::SetPropertyIgnoringNamedGetter(JSContext *cx, const BaseProxyHandler *handle
}
desc.value().set(vp.get());
if (descIsOwn)
return handler->defineProperty(cx, receiver, id, desc);
if (descIsOwn) {
MOZ_ASSERT(desc.object() == proxy);
return handler->defineProperty(cx, proxy, id, desc);
}
return JSObject::defineGeneric(cx, receiver, id, desc.value(),
desc.getter(), desc.setter(), desc.attributes());
}