wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Flag a side exit as loop exit only if the underlying loop condition actually targets the current loop header, otherwise treat it as a branch exit. This is required for inner loops where we unroll the first iteration but the loop condition immediately fails. If we report such exits as loop exits, no branch gets ever attached to them and we keep side-exiting over and over.

Browse Source
This commit is contained in:
Andreas Gal 2008-08-26 21:43:59 -07:00
parent 357f1d4e64
commit 418b15eadd
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/src/jstracer.cpp
View File

@ -1248,7 +1248,7 @@ TraceRecorder::get(jsval* p)
/* Determine whether a bytecode location (pc) terminates a loop or is a path within the loop. */
static bool
js_IsLoopExit(JSContext* cx, JSScript* script, jsbytecode* pc)
js_IsLoopExit(JSContext* cx, JSScript* script, jsbytecode* header, jsbytecode* pc)
{
switch (*pc) {
case JSOP_LT:
@ -1271,7 +1271,7 @@ js_IsLoopExit(JSContext* cx, JSScript* script, jsbytecode* pc)
*/
if (pc[GET_JUMP_OFFSET(pc)] == JSOP_ENDITER)
return true;
return GET_JUMP_OFFSET(pc) < 0;
return pc + GET_JUMP_OFFSET(pc) == header;
default:;
}
@ -1355,7 +1355,8 @@ SideExit*
TraceRecorder::snapshot(ExitType exitType)
{
JSStackFrame* fp = cx->fp;
if (exitType == BRANCH_EXIT && js_IsLoopExit(cx, fp->script, fp->regs->pc))
if (exitType == BRANCH_EXIT &&
js_IsLoopExit(cx, fp->script, (jsbytecode*)fragment->root->ip, fp->regs->pc))
exitType = LOOP_EXIT;
/* Generate the entry map and stash it in the trace. */
unsigned stackSlots = js_NativeStackSlots(cx, callDepth);