Bug 1117038 - Mark virtual overridden functions as MOZ_OVERRIDE in Web Audio; r=padenot

This commit is contained in:
Ehsan Akhgari 2015-01-02 01:12:54 -05:00
parent 50e550fea1
commit 4076832081
25 changed files with 33 additions and 33 deletions

View File

@ -53,7 +53,7 @@ public:
} }
void SetSmoothingTimeConstant(double aValue, ErrorResult& aRv); void SetSmoothingTimeConstant(double aValue, ErrorResult& aRv);
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "AnalyserNode"; return "AnalyserNode";
} }

View File

@ -92,7 +92,7 @@ public:
NS_ERROR("Bad AudioBufferSourceNodeEngine TimelineParameter"); NS_ERROR("Bad AudioBufferSourceNodeEngine TimelineParameter");
} }
} }
virtual void SetStreamTimeParameter(uint32_t aIndex, StreamTime aParam) virtual void SetStreamTimeParameter(uint32_t aIndex, StreamTime aParam) MOZ_OVERRIDE
{ {
switch (aIndex) { switch (aIndex) {
case AudioBufferSourceNode::STOP: mStop = aParam; break; case AudioBufferSourceNode::STOP: mStop = aParam; break;
@ -100,7 +100,7 @@ public:
NS_ERROR("Bad AudioBufferSourceNodeEngine StreamTimeParameter"); NS_ERROR("Bad AudioBufferSourceNodeEngine StreamTimeParameter");
} }
} }
virtual void SetDoubleParameter(uint32_t aIndex, double aParam) virtual void SetDoubleParameter(uint32_t aIndex, double aParam) MOZ_OVERRIDE
{ {
switch (aIndex) { switch (aIndex) {
case AudioBufferSourceNode::START: case AudioBufferSourceNode::START:
@ -117,7 +117,7 @@ public:
NS_ERROR("Bad AudioBufferSourceNodeEngine double parameter."); NS_ERROR("Bad AudioBufferSourceNodeEngine double parameter.");
}; };
} }
virtual void SetInt32Parameter(uint32_t aIndex, int32_t aParam) virtual void SetInt32Parameter(uint32_t aIndex, int32_t aParam) MOZ_OVERRIDE
{ {
switch (aIndex) { switch (aIndex) {
case AudioBufferSourceNode::SAMPLE_RATE: mBufferSampleRate = aParam; break; case AudioBufferSourceNode::SAMPLE_RATE: mBufferSampleRate = aParam; break;
@ -134,7 +134,7 @@ public:
NS_ERROR("Bad AudioBufferSourceNodeEngine Int32Parameter"); NS_ERROR("Bad AudioBufferSourceNodeEngine Int32Parameter");
} }
} }
virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) MOZ_OVERRIDE
{ {
mBuffer = aBuffer; mBuffer = aBuffer;
} }
@ -427,7 +427,7 @@ public:
virtual void ProcessBlock(AudioNodeStream* aStream, virtual void ProcessBlock(AudioNodeStream* aStream,
const AudioChunk& aInput, const AudioChunk& aInput,
AudioChunk* aOutput, AudioChunk* aOutput,
bool* aFinished) bool* aFinished) MOZ_OVERRIDE
{ {
if (!mBuffer || !mBufferEnd) { if (!mBuffer || !mBufferEnd) {
aOutput->SetNull(WEBAUDIO_BLOCK_SIZE); aOutput->SetNull(WEBAUDIO_BLOCK_SIZE);

View File

@ -92,7 +92,7 @@ public:
virtual void NotifyMainThreadStateChanged() MOZ_OVERRIDE; virtual void NotifyMainThreadStateChanged() MOZ_OVERRIDE;
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "AudioBufferSourceNode"; return "AudioBufferSourceNode";
} }

View File

@ -262,7 +262,7 @@ private:
size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const; size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const;
NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport, NS_IMETHOD CollectReports(nsIHandleReportCallback* aHandleReport,
nsISupports* aData, bool aAnonymize); nsISupports* aData, bool aAnonymize) MOZ_OVERRIDE;
friend struct ::mozilla::WebAudioDecodeJob; friend struct ::mozilla::WebAudioDecodeJob;

View File

@ -59,7 +59,7 @@ public:
void OfflineShutdown(); void OfflineShutdown();
// nsIDOMEventListener - by proxy // nsIDOMEventListener - by proxy
NS_IMETHOD HandleEvent(nsIDOMEvent* aEvent); NS_IMETHOD HandleEvent(nsIDOMEvent* aEvent) MOZ_OVERRIDE;
AudioChannel MozAudioChannelType() const; AudioChannel MozAudioChannelType() const;
void SetMozAudioChannelType(AudioChannel aValue, ErrorResult& aRv); void SetMozAudioChannelType(AudioChannel aValue, ErrorResult& aRv);
@ -76,7 +76,7 @@ public:
void CreateAudioChannelAgent(); void CreateAudioChannelAgent();
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "AudioDestinationNode"; return "AudioDestinationNode";
} }

View File

@ -56,7 +56,7 @@ public:
const Float32Array& aMagResponse, const Float32Array& aMagResponse,
const Float32Array& aPhaseResponse); const Float32Array& aPhaseResponse);
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "BiquadFilterNode"; return "BiquadFilterNode";
} }

View File

@ -26,7 +26,7 @@ public:
virtual uint16_t NumberOfInputs() const MOZ_OVERRIDE { return mInputCount; } virtual uint16_t NumberOfInputs() const MOZ_OVERRIDE { return mInputCount; }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "ChannelMergerNode"; return "ChannelMergerNode";
} }

View File

@ -26,7 +26,7 @@ public:
virtual uint16_t NumberOfOutputs() const MOZ_OVERRIDE { return mOutputCount; } virtual uint16_t NumberOfOutputs() const MOZ_OVERRIDE { return mOutputCount; }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "ChannelSplitterNode"; return "ChannelSplitterNode";
} }

View File

@ -73,7 +73,7 @@ public:
NS_ERROR("Bad ConvolverNodeEngine DoubleParameter"); NS_ERROR("Bad ConvolverNodeEngine DoubleParameter");
} }
} }
virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) MOZ_OVERRIDE
{ {
mBuffer = aBuffer; mBuffer = aBuffer;
AdjustReverb(); AdjustReverb();
@ -104,7 +104,7 @@ public:
virtual void ProcessBlock(AudioNodeStream* aStream, virtual void ProcessBlock(AudioNodeStream* aStream,
const AudioChunk& aInput, const AudioChunk& aInput,
AudioChunk* aOutput, AudioChunk* aOutput,
bool* aFinished) bool* aFinished) MOZ_OVERRIDE
{ {
if (!mReverb) { if (!mReverb) {
*aOutput = aInput; *aOutput = aInput;

View File

@ -54,7 +54,7 @@ public:
AudioNode::SetChannelCountModeValue(aMode, aRv); AudioNode::SetChannelCountModeValue(aMode, aRv);
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "ConvolverNode"; return "ConvolverNode";
} }

View File

@ -47,7 +47,7 @@ public:
{ {
} }
virtual DelayNodeEngine* AsDelayNodeEngine() virtual DelayNodeEngine* AsDelayNodeEngine() MOZ_OVERRIDE
{ {
return this; return this;
} }

View File

@ -30,7 +30,7 @@ public:
return mDelay; return mDelay;
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "DelayNode"; return "DelayNode";
} }

View File

@ -56,7 +56,7 @@ public:
return mRelease; return mRelease;
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "DynamicsCompressorNode"; return "DynamicsCompressorNode";
} }

View File

@ -61,7 +61,7 @@ public:
virtual void ProcessBlock(AudioNodeStream* aStream, virtual void ProcessBlock(AudioNodeStream* aStream,
const AudioChunk& aInput, const AudioChunk& aInput,
AudioChunk* aOutput, AudioChunk* aOutput,
bool* aFinished) bool* aFinished) MOZ_OVERRIDE
{ {
MOZ_ASSERT(mSource == aStream, "Invalid source stream"); MOZ_ASSERT(mSource == aStream, "Invalid source stream");

View File

@ -30,7 +30,7 @@ public:
return mGain; return mGain;
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "GainNode"; return "GainNode";
} }

View File

@ -20,7 +20,7 @@ public:
virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE; virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE;
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "MediaElementAudioSourceNode"; return "MediaElementAudioSourceNode";
} }

View File

@ -34,7 +34,7 @@ public:
return mDOMStream; return mDOMStream;
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "MediaStreamAudioDestinationNode"; return "MediaStreamAudioDestinationNode";
} }

View File

@ -54,7 +54,7 @@ public:
virtual uint16_t NumberOfInputs() const MOZ_OVERRIDE { return 0; } virtual uint16_t NumberOfInputs() const MOZ_OVERRIDE { return 0; }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "MediaStreamAudioSourceNode"; return "MediaStreamAudioSourceNode";
} }

View File

@ -116,7 +116,7 @@ public:
} }
} }
virtual void SetStreamTimeParameter(uint32_t aIndex, StreamTime aParam) virtual void SetStreamTimeParameter(uint32_t aIndex, StreamTime aParam) MOZ_OVERRIDE
{ {
switch (aIndex) { switch (aIndex) {
case START: mStart = aParam; break; case START: mStart = aParam; break;
@ -126,7 +126,7 @@ public:
} }
} }
virtual void SetInt32Parameter(uint32_t aIndex, int32_t aParam) virtual void SetInt32Parameter(uint32_t aIndex, int32_t aParam) MOZ_OVERRIDE
{ {
switch (aIndex) { switch (aIndex) {
case TYPE: case TYPE:
@ -183,7 +183,7 @@ public:
// End index switch. // End index switch.
} }
virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) virtual void SetBuffer(already_AddRefed<ThreadSharedFloatArrayBufferList> aBuffer) MOZ_OVERRIDE
{ {
MOZ_ASSERT(mCustomLength, "Custom buffer sent before length"); MOZ_ASSERT(mCustomLength, "Custom buffer sent before length");
mCustom = aBuffer; mCustom = aBuffer;

View File

@ -80,7 +80,7 @@ public:
virtual void NotifyMainThreadStateChanged() MOZ_OVERRIDE; virtual void NotifyMainThreadStateChanged() MOZ_OVERRIDE;
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "OscillatorNode"; return "OscillatorNode";
} }

View File

@ -195,7 +195,7 @@ public:
void FindConnectedSources(); void FindConnectedSources();
void FindConnectedSources(AudioNode* aNode, nsTArray<AudioBufferSourceNode*>& aSources, std::set<AudioNode*>& aSeenNodes); void FindConnectedSources(AudioNode* aNode, nsTArray<AudioBufferSourceNode*>& aSources, std::set<AudioNode*>& aSeenNodes);
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "PannerNode"; return "PannerNode";
} }

View File

@ -88,7 +88,7 @@ public:
using DOMEventTargetHelper::DispatchTrustedEvent; using DOMEventTargetHelper::DispatchTrustedEvent;
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "ScriptProcessorNode"; return "ScriptProcessorNode";
} }

View File

@ -48,7 +48,7 @@ public:
NS_DECL_ISUPPORTS_INHERITED NS_DECL_ISUPPORTS_INHERITED
NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(StereoPannerNode, AudioNode) NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(StereoPannerNode, AudioNode)
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "StereoPannerNode"; return "StereoPannerNode";
} }

View File

@ -217,7 +217,7 @@ public:
virtual void ProcessBlock(AudioNodeStream* aStream, virtual void ProcessBlock(AudioNodeStream* aStream,
const AudioChunk& aInput, const AudioChunk& aInput,
AudioChunk* aOutput, AudioChunk* aOutput,
bool* aFinished) bool* aFinished) MOZ_OVERRIDE
{ {
uint32_t channelCount = aInput.mChannelData.Length(); uint32_t channelCount = aInput.mChannelData.Length();
if (!mCurve.Length() || !channelCount) { if (!mCurve.Length() || !channelCount) {

View File

@ -48,7 +48,7 @@ public:
return AudioNode::SizeOfExcludingThis(aMallocSizeOf); return AudioNode::SizeOfExcludingThis(aMallocSizeOf);
} }
virtual const char* NodeType() const virtual const char* NodeType() const MOZ_OVERRIDE
{ {
return "WaveShaperNode"; return "WaveShaperNode";
} }