mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
Bug 597218 - It shouldn't be possible for app tabs to be hidden r=dao, a=blocking
--HG-- extra : rebase_source : eb41328eaf2f74fcfd83b6fc800f377a24e1f890
This commit is contained in:
Ian Gilman
parent
67c210ca8d
commit
3f245a17aa
@ -183,6 +183,9 @@
|
||||
if (aTab.pinned)
|
||||
return;
|
||||
|
||||
if (aTab.hidden)
|
||||
this.showTab(aTab);
|
||||
|
||||
this.moveTabTo(aTab, this._numPinnedTabs);
|
||||
aTab.setAttribute("pinned", "true");
|
||||
this.tabContainer._positionPinnedTabs();
|
||||
@ -1822,7 +1825,7 @@
|
||||
<body>
|
||||
<![CDATA[
|
||||
if (aTab.hidden) {
|
||||
aTab.hidden = false;
|
||||
aTab.removeAttribute("hidden");
|
||||
let event = document.createEvent("Events");
|
||||
event.initEvent("TabShow", true, false);
|
||||
aTab.dispatchEvent(event);
|
||||
@ -1837,7 +1840,7 @@
|
||||
<![CDATA[
|
||||
if (!aTab.hidden && !aTab.pinned && !aTab.selected &&
|
||||
this._removingTabs.indexOf(aTab) == -1) {
|
||||
aTab.hidden = true;
|
||||
aTab.setAttribute("hidden", "true");
|
||||
let event = document.createEvent("Events");
|
||||
event.initEvent("TabHide", true, false);
|
||||
aTab.dispatchEvent(event);
|
||||
@ -3328,6 +3331,11 @@
|
||||
return this.getAttribute("pinned") == "true";
|
||||
</getter>
|
||||
</property>
|
||||
<property name="hidden" readonly="true">
|
||||
<getter>
|
||||
return this.getAttribute("hidden") == "true";
|
||||
</getter>
|
||||
</property>
|
||||
|
||||
<field name="mOverCloseButton">false</field>
|
||||
<field name="mCorrespondingMenuitem">null</field>
|
||||
|
||||
@ -155,6 +155,7 @@ _BROWSER_FILES = \
|
||||
browser_bug594131.js \
|
||||
browser_bug595507.js \
|
||||
browser_bug596687.js \
|
||||
browser_bug597218.js \
|
||||
browser_contextSearchTabPosition.js \
|
||||
browser_ctrlTab.js \
|
||||
browser_discovery.js \
|
||||
|
||||
72
browser/base/content/test/browser_bug597218.js
Normal file
72
browser/base/content/test/browser_bug597218.js
Normal file
@ -0,0 +1,72 @@
|
||||
/* ***** BEGIN LICENSE BLOCK *****
|
||||
* Version: MPL 1.1/GPL 2.0/LGPL 2.1
|
||||
*
|
||||
* The contents of this file are subject to the Mozilla Public License Version
|
||||
* 1.1 (the "License"); you may not use this file except in compliance with
|
||||
* the License. You may obtain a copy of the License at
|
||||
* http://www.mozilla.org/MPL/
|
||||
*
|
||||
* Software distributed under the License is distributed on an "AS IS" basis,
|
||||
* WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
|
||||
* for the specific language governing rights and limitations under the
|
||||
* License.
|
||||
*
|
||||
* The Original Code is bug 597218 test.
|
||||
*
|
||||
* The Initial Developer of the Original Code is
|
||||
* Mozilla Foundation.
|
||||
* Portions created by the Initial Developer are Copyright (C) 2010
|
||||
* the Initial Developer. All Rights Reserved.
|
||||
*
|
||||
* Contributor(s):
|
||||
* Raymond Lee <raymond@appcoast.com>
|
||||
* Ian Gilman <ian@iangilman.com>
|
||||
*
|
||||
* Alternatively, the contents of this file may be used under the terms of
|
||||
* either the GNU General Public License Version 2 or later (the "GPL"), or
|
||||
* the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
|
||||
* in which case the provisions of the GPL or the LGPL are applicable instead
|
||||
* of those above. If you wish to allow use of your version of this file only
|
||||
* under the terms of either the GPL or the LGPL, and not to allow others to
|
||||
* use your version of this file under the terms of the MPL, indicate your
|
||||
* decision by deleting the provisions above and replace them with the notice
|
||||
* and other provisions required by the GPL or the LGPL. If you do not delete
|
||||
* the provisions above, a recipient may use your version of this file under
|
||||
* the terms of any one of the MPL, the GPL or the LGPL.
|
||||
*
|
||||
* ***** END LICENSE BLOCK ***** */
|
||||
|
||||
function test() {
|
||||
waitForExplicitFinish();
|
||||
|
||||
// establish initial state
|
||||
is(gBrowser.tabs.length, 1, "we start with one tab");
|
||||
|
||||
// create a tab
|
||||
let tab = gBrowser.loadOneTab("about:blank");
|
||||
ok(!tab.hidden, "tab starts out not hidden");
|
||||
is(gBrowser.tabs.length, 2, "we now have two tabs");
|
||||
|
||||
// make sure .hidden is read-only
|
||||
tab.hidden = true;
|
||||
ok(!tab.hidden, "can't set .hidden directly");
|
||||
|
||||
// hide the tab
|
||||
gBrowser.hideTab(tab);
|
||||
ok(tab.hidden, "tab is hidden");
|
||||
|
||||
// now pin it and make sure it gets unhidden
|
||||
gBrowser.pinTab(tab);
|
||||
ok(tab.pinned, "tab was pinned");
|
||||
ok(!tab.hidden, "tab was unhidden");
|
||||
|
||||
// try hiding it now that it's pinned; shouldn't be able to
|
||||
gBrowser.hideTab(tab);
|
||||
ok(!tab.hidden, "tab did not hide");
|
||||
|
||||
// clean up
|
||||
gBrowser.removeTab(tab);
|
||||
is(gBrowser.tabs.length, 1, "we finish with one tab");
|
||||
|
||||
finish();
|
||||
}
|
||||
@ -2214,7 +2214,11 @@ SessionStoreService.prototype = {
|
||||
tabbrowser.pinTab(tabs[t]);
|
||||
else
|
||||
tabbrowser.unpinTab(tabs[t]);
|
||||
tabs[t].hidden = winData.tabs[t].hidden;
|
||||
|
||||
if (winData.tabs[t].hidden)
|
||||
tabbrowser.hideTab(tabs[t]);
|
||||
else
|
||||
tabbrowser.showTab(tabs[t]);
|
||||
}
|
||||
|
||||
// If overwriting tabs, we want to remove __SS_restoring from the browser.
|
||||
@ -2376,7 +2380,11 @@ SessionStoreService.prototype = {
|
||||
tabbrowser.pinTab(tab);
|
||||
else
|
||||
tabbrowser.unpinTab(tab);
|
||||
tab.hidden = tabData.hidden;
|
||||
|
||||
if (tabData.hidden)
|
||||
tabbrowser.hideTab(tab);
|
||||
else
|
||||
tabbrowser.showTab(tab);
|
||||
|
||||
tabData._tabStillLoading = true;
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user