Bug 999737-add ESLint to run-all-loop-tests; update docs, rs=Standard, DONTBUILD

This commit is contained in:
Dan Mosedale 2015-04-01 14:08:38 -07:00
parent 9d42b06c63
commit 3ee645a354
3 changed files with 21 additions and 11 deletions

View File

@ -40,6 +40,21 @@ Please be sure to execute
from the top level before requesting review on a patch.
Linting
=======
run-all-loop-tests.sh will take care of this for you automatically, after
you've installed the dependencies by typing:
( cd standalone ; make install )
If you install eslint and the react plugin globally:
npm install -g eslint
npm install -g eslint-plugin-react
You can also run it by hand in the browser/components/loop directory:
eslint .
Front-End Unit Tests
====================

View File

@ -12,12 +12,12 @@ set -e
# Main tests
LOOPDIR=browser/components/loop
#ESLINT=standalone/node_modules/.bin/eslint
#if [ -x "${LOOPDIR}/${ESLINT}" ]; then
# echo 'running eslint; see http://eslint.org/docs/rules/ for error info'
# (cd ${LOOPDIR} && ./${ESLINT} .)
# echo 'eslint run finished.'
#fi
ESLINT=standalone/node_modules/.bin/eslint
if [ -x "${LOOPDIR}/${ESLINT}" ]; then
echo 'running eslint; see http://eslint.org/docs/rules/ for error info'
(cd ${LOOPDIR} && ./${ESLINT} .)
echo 'eslint run finished.'
fi
./mach xpcshell-test ${LOOPDIR}/
./mach marionette-test ${LOOPDIR}/manifest.ini

View File

@ -48,11 +48,6 @@ Then point your browser at:
**Note:** the provided static file server for web contents is **not** intended
for production use.
Code linting
------------
$ make lint
License
-------