Bug 563487. removeEventListener on a Window shouldn't throw if there's not listener manager yet; just do nothing. r=smaug

This commit is contained in:
Boris Zbarsky 2010-05-05 14:18:04 -04:00
parent e19f8c4e1a
commit 3c3a1ca782
3 changed files with 37 additions and 2 deletions

View File

@ -6651,9 +6651,8 @@ nsGlobalWindow::RemoveGroupedEventListener(const nsAString & aType,
mListenerManager->RemoveEventListenerByType(aListener, aType, flags,
aEvtGrp);
return NS_OK;
}
return NS_ERROR_FAILURE;
return NS_OK;
}
NS_IMETHODIMP

View File

@ -112,6 +112,7 @@ _TEST_FILES = \
test_bug531542.html \
test_bug456151.html \
test_bug558973.html \
test_bug563487.html \
$(NULL)
libs:: $(_TEST_FILES)

View File

@ -0,0 +1,35 @@
<!DOCTYPE HTML>
<html>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=563487
-->
<head>
<!-- Put this before the mochi* stuff, since that adds various listeners -->
<script>
var exception = null;
try {
window.removeEventListener("foo", function() {}, false);
} catch (e) {
exception = e;
}
</script>
<title>Test for Bug 563487</title>
<script type="application/javascript" src="/MochiKit/packed.js"></script>
<script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
</head>
<body>
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=563487">Mozilla Bug 563487</a>
<p id="display"></p>
<div id="content" style="display: none">
</div>
<pre id="test">
<script type="application/javascript">
/** Test for Bug 563487 **/
is(exception, null, "removeEventListener threw");
</script>
</pre>
</body>
</html>