Bug 1246170 - Remove about:logins histogram telemetry probes. r=mfinkle

This commit is contained in:
Margaret Leibovic 2016-02-05 10:11:54 -05:00
parent d0095b992d
commit 39e38e1e79
2 changed files with 0 additions and 24 deletions

View File

@ -40,11 +40,6 @@ function copyStringShowSnackbar(string, notifyString) {
// Delay filtering while typing in MS
const FILTER_DELAY = 500;
/* Constants for usage telemetry */
const LOGINS_LIST_VIEWED = 0;
const LOGIN_VIEWED = 1;
const LOGIN_EDITED = 2;
const LOGIN_PW_TOGGLED = 3;
var Logins = {
_logins: [],
@ -71,9 +66,7 @@ var Logins = {
let getAllLogins = () => {
let logins = [];
try {
TelemetryStopwatch.start("PWMGR_ABOUT_LOGINS_GET_ALL_LOGINS_MS");
logins = Services.logins.getAllLogins();
TelemetryStopwatch.finish("PWMGR_ABOUT_LOGINS_GET_ALL_LOGINS_MS");
} catch(e) {
// It's likely that the Master Password was not entered; give
// a hint to the next person.
@ -226,7 +219,6 @@ var Logins = {
},
_showList: function () {
Services.telemetry.getHistogramById("PWMGR_ABOUT_LOGINS_USAGE").add(LOGINS_LIST_VIEWED);
let loginsListPage = document.getElementById("logins-list-page");
loginsListPage.classList.remove("hidden");
@ -249,7 +241,6 @@ var Logins = {
}
},
_showEditLoginDialog: function (login) {
Services.telemetry.getHistogramById("PWMGR_ABOUT_LOGINS_USAGE").add(LOGIN_VIEWED);
let listPage = document.getElementById("logins-list-page");
listPage.classList.add("hidden");
@ -289,7 +280,6 @@ var Logins = {
},
_onSaveEditLogin: function() {
Services.telemetry.getHistogramById("PWMGR_ABOUT_LOGINS_USAGE").add(LOGIN_EDITED);
let newUsername = document.getElementById("username").value;
let newPassword = document.getElementById("password").value;
let newDomain = document.getElementById("hostname").value;
@ -328,7 +318,6 @@ var Logins = {
},
_onPasswordBtn: function () {
Services.telemetry.getHistogramById("PWMGR_ABOUT_LOGINS_USAGE").add(LOGIN_PW_TOGGLED);
this._updatePasswordBtn(this._isPasswordBtnInHideMode());
},

View File

@ -8719,19 +8719,6 @@
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize the open windows list (ms)"
},
"PWMGR_ABOUT_LOGINS_GET_ALL_LOGINS_MS": {
"expires_in_version": "55",
"kind": "exponential",
"high": 60000,
"n_buckets": 30,
"description": "How long getAllLogins() on about:logins takes for mobile users"
},
"PWMGR_ABOUT_LOGINS_USAGE": {
"expires_in_version": "55",
"kind": "enumerated",
"n_values": 12,
"description": "Usage of about:logins 0= list of logins viewed, 1=a login's specifics page was viewed, 2=user edited login credentials 3=user toggled the show/hide button"
},
"PWMGR_BLOCKLIST_NUM_SITES": {
"expires_in_version": "never",
"kind": "exponential",