wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 875304, part 1b - remove pointless AppendElement checks from CC. r=smaug

Browse Source
This commit is contained in:
Andrew McCreight 2013-06-03 10:43:17 -07:00
parent af85c48452
commit 380060a9a6
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
xpcom/base/nsCycleCollector.cpp
View File

@ -1475,7 +1475,6 @@ public:
}
if (mWantAfterProcessing) {
CCGraphDescriber* d = mDescribers.AppendElement();
NS_ENSURE_TRUE(d, NS_ERROR_OUT_OF_MEMORY);
mCurrentAddress.AssignLiteral("0x");
mCurrentAddress.AppendInt(aAddress, 16);
d->mType = CCGraphDescriber::eRefCountedObject;
@ -1494,7 +1493,6 @@ public:
}
if (mWantAfterProcessing) {
CCGraphDescriber* d = mDescribers.AppendElement();
NS_ENSURE_TRUE(d, NS_ERROR_OUT_OF_MEMORY);
mCurrentAddress.AssignLiteral("0x");
mCurrentAddress.AppendInt(aAddress, 16);
d->mType = aMarked ? CCGraphDescriber::eGCMarkedObject :
@ -1511,7 +1509,6 @@ public:
}
if (mWantAfterProcessing) {
CCGraphDescriber* d = mDescribers.AppendElement();
NS_ENSURE_TRUE(d, NS_ERROR_OUT_OF_MEMORY);
d->mType = CCGraphDescriber::eEdge;
d->mAddress = mCurrentAddress;
d->mToAddress.AppendInt(aToAddress, 16);
@ -1533,7 +1530,6 @@ public:
}
if (mWantAfterProcessing) {
CCGraphDescriber* d = mDescribers.AppendElement();
NS_ENSURE_TRUE(d, NS_ERROR_OUT_OF_MEMORY);
d->mType = CCGraphDescriber::eRoot;
d->mAddress.AppendInt(aAddress, 16);
d->mCnt = aKnownEdges;
@ -1547,7 +1543,6 @@ public:
}
if (mWantAfterProcessing) {
CCGraphDescriber* d = mDescribers.AppendElement();
NS_ENSURE_TRUE(d, NS_ERROR_OUT_OF_MEMORY);
d->mType = CCGraphDescriber::eGarbage;
d->mAddress.AppendInt(aAddress, 16);
}
@ -2361,7 +2356,8 @@ nsCycleCollector::CollectWhite(nsICycleCollectorListener *aListener)
while (!etor.IsDone())
{
PtrInfo *pinfo = etor.GetNext();
if (pinfo->mColor == white && mWhiteNodes->AppendElement(pinfo)) {
if (pinfo->mColor == white) {
mWhiteNodes->AppendElement(pinfo);
rv = pinfo->mParticipant->Root(pinfo->mPointer);
if (NS_FAILED(rv)) {
Fault("Failed root call while unlinking", pinfo);