wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow scripted getters or setters on XPCNativeWrappers. bug 387390, r=jst sr=brendan

Browse Source
This commit is contained in:
mrbkap@gmail.com 2008-01-04 17:37:48 -08:00
parent cfbfe3c2cd
commit 3706fb3053
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
js/src/xpconnect/src/XPCNativeWrapper.cpp
View File

@ -276,6 +276,25 @@ XPC_NW_WrapFunction(JSContext* cx, JSObject* funobj, jsval *rval)
JS_STATIC_DLL_CALLBACK(JSBool) JS_STATIC_DLL_CALLBACK(JSBool)
XPC_NW_AddProperty(JSContext *cx, JSObject *obj, jsval id, jsval *vp) XPC_NW_AddProperty(JSContext *cx, JSObject *obj, jsval id, jsval *vp)
{ {
JSProperty *prop;
JSObject *pobj;
jsid idAsId;
if (!::JS_ValueToId(cx, id, &idAsId) ||
!OBJ_LOOKUP_PROPERTY(cx, obj, idAsId, &pobj, &prop)) {
return JS_FALSE;
}
// Do not allow scripted getters or setters on XPCNativeWrappers.
NS_ASSERTION(prop && pobj == obj, "Wasn't this property just added?");
JSScopeProperty *sprop = (JSScopeProperty *) prop;
uint8 attrs = sprop->attrs;
OBJ_DROP_PROPERTY(cx, pobj, prop);
if (attrs & (JSPROP_GETTER | JSPROP_SETTER)) {
return ThrowException(NS_ERROR_ILLEGAL_VALUE, cx);
}
jsval flags; jsval flags;
::JS_GetReservedSlot(cx, obj, 0, &flags); ::JS_GetReservedSlot(cx, obj, 0, &flags);
if (!HAS_FLAGS(flags, FLAG_RESOLVING)) { if (!HAS_FLAGS(flags, FLAG_RESOLVING)) {