wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1048013 - Fix some bad implicit constructors in MFBT; r=froydnj

Browse Source
This commit is contained in:
Ehsan Akhgari 2014-08-05 09:21:12 -04:00
parent 7207465c1b
commit 3508dd19c8
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mfbt/WeakPtr.h
View File

@ -183,7 +183,7 @@ public:
return *this = aOther->SelfReferencingWeakPtr();
}
WeakPtr(T* aOther)
MOZ_IMPLICIT WeakPtr(T* aOther)
{
*this = aOther;
}

10
mfbt/tests/TestPair.cpp
View File

@ -29,21 +29,21 @@ using mozilla::Pair;
INSTANTIATE(int, int, prim1, 2 * sizeof(int));
INSTANTIATE(int, long, prim2, 2 * sizeof(long));
struct EmptyClass { EmptyClass(int) {} };
struct NonEmpty { char mC; NonEmpty(int) {} };
struct EmptyClass { explicit EmptyClass(int) {} };
struct NonEmpty { char mC; explicit NonEmpty(int) {} };
INSTANTIATE(int, EmptyClass, both1, sizeof(int));
INSTANTIATE(int, NonEmpty, both2, 2 * sizeof(int));
INSTANTIATE(EmptyClass, NonEmpty, both3, 1);
struct A { char dummy; A(int) {} };
struct B : A { B(int aI) : A(aI) {} };
struct A { char dummy; explicit A(int) {} };
struct B : A { explicit B(int aI) : A(aI) {} };
INSTANTIATE(A, A, class1, 2);
INSTANTIATE(A, B, class2, 2);
INSTANTIATE(A, EmptyClass, class3, 1);
struct OtherEmpty : EmptyClass { OtherEmpty(int aI) : EmptyClass(aI) {} };
struct OtherEmpty : EmptyClass { explicit OtherEmpty(int aI) : EmptyClass(aI) {} };
// C++11 requires distinct objects of the same type, within the same "most
// derived object", to have different addresses. Pair allocates its elements as

2
mfbt/tests/TestSplayTree.cpp
View File

@ -89,7 +89,7 @@ static int gValues[] = {
struct SplayInt : SplayTreeNode<SplayInt>
{
SplayInt(int aValue) : mValue(aValue) {}
explicit SplayInt(int aValue) : mValue(aValue) {}
static int compare(const SplayInt& aOne, const SplayInt& aTwo)
{