From 3447d22f47762ecd4b146397928940e5fd7f1743 Mon Sep 17 00:00:00 2001 From: Kannan Vijayan Date: Mon, 21 Oct 2013 14:39:29 -0400 Subject: [PATCH] Backout 38d2cbc11868 for jsreftest failures. CLOSED TREE. --- js/src/jit/BaselineIC.cpp | 2 +- js/src/jit/IonCaches.cpp | 2 +- js/src/vm/Interpreter-inl.h | 2 +- js/src/vm/Interpreter.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/js/src/jit/BaselineIC.cpp b/js/src/jit/BaselineIC.cpp index 9910ee6ec4a..63bc919a7b3 100644 --- a/js/src/jit/BaselineIC.cpp +++ b/js/src/jit/BaselineIC.cpp @@ -6015,7 +6015,7 @@ DoGetPropFallback(JSContext *cx, BaselineFrame *frame, ICGetProp_Fallback *stub, #if JS_HAS_NO_SUCH_METHOD // Handle objects with __noSuchMethod__. - if (op == JSOP_CALLPROP && JS_UNLIKELY(res.isUndefined()) && val.isObject()) { + if (op == JSOP_CALLPROP && JS_UNLIKELY(res.isPrimitive()) && val.isObject()) { if (!OnUnknownMethod(cx, obj, IdToValue(id), res)) return false; } diff --git a/js/src/jit/IonCaches.cpp b/js/src/jit/IonCaches.cpp index a09fab5fd93..8516e53a830 100644 --- a/js/src/jit/IonCaches.cpp +++ b/js/src/jit/IonCaches.cpp @@ -1781,7 +1781,7 @@ GetPropertyIC::update(JSContext *cx, size_t cacheIndex, #if JS_HAS_NO_SUCH_METHOD // Handle objects with __noSuchMethod__. - if (JSOp(*pc) == JSOP_CALLPROP && JS_UNLIKELY(vp.isUndefined())) { + if (JSOp(*pc) == JSOP_CALLPROP && JS_UNLIKELY(vp.isPrimitive())) { if (!OnUnknownMethod(cx, obj, IdToValue(id), vp)) return false; } diff --git a/js/src/vm/Interpreter-inl.h b/js/src/vm/Interpreter-inl.h index a9e4fc124c7..43fd67ee8ba 100644 --- a/js/src/vm/Interpreter-inl.h +++ b/js/src/vm/Interpreter-inl.h @@ -391,7 +391,7 @@ GetObjectElementOperation(JSContext *cx, JSOp op, JSObject *objArg, bool wasObje } while (0); #if JS_HAS_NO_SUCH_METHOD - if (op == JSOP_CALLELEM && JS_UNLIKELY(res.isUndefined()) && wasObject) { + if (op == JSOP_CALLELEM && JS_UNLIKELY(res.isPrimitive()) && wasObject) { RootedObject obj(cx, objArg); if (!OnUnknownMethod(cx, obj, rref, res)) return false; diff --git a/js/src/vm/Interpreter.cpp b/js/src/vm/Interpreter.cpp index dbbbbdb762b..5eed207afe3 100644 --- a/js/src/vm/Interpreter.cpp +++ b/js/src/vm/Interpreter.cpp @@ -266,7 +266,7 @@ GetPropertyOperation(JSContext *cx, StackFrame *fp, HandleScript script, jsbytec #if JS_HAS_NO_SUCH_METHOD if (op == JSOP_CALLPROP && - JS_UNLIKELY(vp.isUndefined()) && + JS_UNLIKELY(vp.isPrimitive()) && wasObject) { if (!OnUnknownMethod(cx, obj, IdToValue(id), vp)) @@ -3453,7 +3453,7 @@ js::CallProperty(JSContext *cx, HandleValue v, HandlePropertyName name, MutableH return false; #if JS_HAS_NO_SUCH_METHOD - if (JS_UNLIKELY(vp.isUndefined()) && v.isObject()) + if (JS_UNLIKELY(vp.isPrimitive()) && v.isObject()) { RootedObject obj(cx, &v.toObject()); if (!OnUnknownMethod(cx, obj, StringValue(name), vp))