wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 932837 part 4. Allocate the caller JSStackFrames lazily. r=khuey

Browse Source
This commit is contained in:
Boris Zbarsky 2014-01-07 19:53:18 -05:00
parent a3c5efa374
commit 319c00dd7b
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
dom/bindings/Exceptions.cpp
View File

@ -310,6 +310,7 @@ private:
bool mFilenameInitialized;
bool mFunnameInitialized;
bool mLinenoInitialized;
bool mCallerInitialized;
};
JSStackFrame::JSStackFrame(StackDescriptionOwner* aStackDescription,
@ -324,6 +325,7 @@ JSStackFrame::JSStackFrame(StackDescriptionOwner* aStackDescription,
mFilenameInitialized = false;
mFunnameInitialized = false;
mLinenoInitialized = false;
mCallerInitialized = false;
mLanguage = nsIProgrammingLanguage::JAVASCRIPT;
} else {
MOZ_ASSERT(!mStackDescription);
@ -331,6 +333,7 @@ JSStackFrame::JSStackFrame(StackDescriptionOwner* aStackDescription,
mFilenameInitialized = true;
mFunnameInitialized = true;
mLinenoInitialized = true;
mCallerInitialized = true;
mLanguage = nsIProgrammingLanguage::UNKNOWN;
}
}
@ -485,6 +488,10 @@ NS_IMETHODIMP JSStackFrame::GetSourceLine(char** aSourceLine)
/* readonly attribute nsIStackFrame caller; */
NS_IMETHODIMP JSStackFrame::GetCaller(nsIStackFrame** aCaller)
{
if (!mCallerInitialized) {
mCaller = new JSStackFrame(mStackDescription, mIndex+1);
mCallerInitialized = true;
}
NS_IF_ADDREF(*aCaller = mCaller);
return NS_OK;
}
@ -524,23 +531,7 @@ JSStackFrame::CreateStack(JSContext* cx)
nsRefPtr<StackDescriptionOwner> descOwner = new StackDescriptionOwner(desc);
nsRefPtr<JSStackFrame> first;
nsRefPtr<JSStackFrame> last;
// We create one dummy frame at the end (why?), so go up through
// desc->nframes+1
for (size_t i = 0; i < desc->nframes+1; i++) {
nsRefPtr<JSStackFrame> frame = new JSStackFrame(descOwner, i);
if (last) {
last->mCaller = frame;
} else {
MOZ_ASSERT(!first, "How can we have a first but not a last?");
first = frame;
}
last.swap(frame);
}
nsRefPtr<JSStackFrame> first = new JSStackFrame(descOwner, 0);
return first.forget();
}