Bug 415297: Content styles should control display behaviours, not the theme. r=robstrong

toolkit/mozapps/extensions/content/extensions.css

@@ -206,19 +206,10 @@ richlistitem[action] .addonInstallButton {
   display: none;
 }
 
-richlistitem[action="connecting"] .searchResultConnecting {
-  display: -moz-box;
-}
-
-richlistitem[action="installing"] .searchResultInstalling {
-  display: -moz-box;
-}
-
+richlistitem[action="connecting"] .searchResultConnecting,
+richlistitem[action="installing"] .searchResultInstalling,
 richlistitem[action="failed"] .searchResultFailed,
-richlistitem[action="failed"] .addonInstallButton {
-  display: -moz-box;
-}
-
+richlistitem[action="failed"] .addonInstallButton,
 richlistitem[action="installed"] .searchResultInstalled {
   display: -moz-box;
 }
@@ -234,3 +225,37 @@ richlistitem[addonType="2"] .addonTypeExtension {
 richlistitem[addonType="4"] .addonTypeTheme {
   display: -moz-box;
 }
+
+.updateBadge,
+.updateAvailableBox,
+.notifyBadge {
+  display: none;
+}
+
+richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
+richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
+richlistitem[compatible="false"] .notifyBadge,
+richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
+richlistitem[blocklisted="true"] .notifyBadge,
+richlistitem[blocklistedsoft="true"] .notifyBadge,
+richlistitem[satisfiesDependencies="false"] .notifyBadge,
+richlistitem[loading="true"] .updateBadge {
+  display: -moz-box;
+}
+
+/* Selected Add-on status messages and images */
+richlistitem[compatible="true"] .incompatibleBox,
+richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
+richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
+richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
+richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
+richlistitem[blocklisted="false"] .blocklistedLabel,
+richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
+richlistitem[opType="needs-uninstall"] .blocklistedBox,
+richlistitem[opType="needs-uninstall"] .incompatibleBox,
+richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
+richlistitem[opType="needs-uninstall"] .notifyBadge,
+richlistitem[selected="true"]:not([opType]) .descriptionCrop,
+.addonRating:not([rating]) {
+  display: none;
+}

toolkit/themes/gnomestripe/mozapps/extensions/extensions.css

@@ -91,10 +91,6 @@ richlistitem[selected="true"] .text-link {
   margin-bottom: 2px;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addonName {
   font-weight: bold;
 }
@@ -155,22 +151,6 @@ richlistitem[selected="true"]:not([opType]) .descriptionCrop {
   list-style-image: url("moz-icon://stock/gtk-dialog-error?size=menu");
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
@@ -195,23 +175,7 @@ richlistitem[satisfiesDependencies="false"] .notifyBadge {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
@@ -241,10 +205,6 @@ richlistitem[loading="true"] .updateBadge {
   border: none;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
@@ -273,17 +233,12 @@ richlistitem[opType="needs-uninstall"] .notifyBadge {
   list-style-image: url("moz-icon://stock/gtk-dialog-error?size=menu");
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 70px;
   height: 14px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");

toolkit/themes/pinstripe/mozapps/extensions/extensions.css

@@ -86,10 +86,6 @@ richlistitem:not([selected="true"]) .addon-description {
   color: #707070;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addon-name-version {
   font-size: 110%;
 }
@@ -152,22 +148,6 @@ richlistitem[selected="true"]:not([opType]) .descriptionCrop {
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
@@ -193,23 +173,7 @@ richlistitem[satisfiesDependencies="false"] .notifyBadge {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
@@ -243,10 +207,6 @@ richlistitem[loading="true"] .updateBadge {
   -moz-box-pack: end;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
@@ -276,17 +236,12 @@ richlistitem[opType="needs-uninstall"] .notifyBadge {
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 78px;
   height: 18px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");

toolkit/themes/winstripe/mozapps/extensions/extensions.css

@@ -81,10 +81,6 @@ richlistitem[selected="true"] .text-link {
   margin-bottom: 2px;
 }
 
-richlistitem[selected="true"]:not([opType]) .descriptionCrop {
-  display: none;
-}
-
 .addonName {
   font-weight: bold;
 }
@@ -146,22 +142,6 @@ richlistitem[selected="true"]:not([opType]) .descriptionCrop {
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.updateBadge,
-.updateAvailableBox,
-.notifyBadge {
-  display: none;
-}
-
-richlistitem[availableUpdateURL][updateable="true"] .updateBadge,
-richlistitem[availableUpdateURL][updateable="true"] .updateAvailableBox,
-richlistitem[compatible="false"] .notifyBadge,
-richlistitem[providesUpdatesSecurely="false"] .notifyBadge,
-richlistitem[blocklisted="true"] .notifyBadge,
-richlistitem[blocklistedsoft="true"] .notifyBadge,
-richlistitem[satisfiesDependencies="false"] .notifyBadge {
-  display: -moz-box;
-}
-
 /* Selected Add-on buttons
    See content/extensions.css to hide / display buttons */
 .selectedButtons {
@@ -186,23 +166,7 @@ richlistitem[satisfiesDependencies="false"] .notifyBadge {
   -moz-margin-start: 5px;
 }
 
-/* Selected Add-on status messages and images */
-richlistitem[compatible="true"] .incompatibleBox,
-richlistitem[providesUpdatesSecurely="true"] .insecureUpdateBox,
-richlistitem[satisfiesDependencies="true"] .needsDependenciesBox,
-richlistitem:not([blocklisted="true"]):not([blocklistedsoft="true"]) .blocklistedBox,
-richlistitem[blocklistedsoft="false"]:not([selected="true"]) .blocklistedBox,
-richlistitem[blocklisted="false"] .blocklistedLabel,
-richlistitem[blocklistedsoft="false"] .softBlocklistedLabel,
-richlistitem[opType="needs-uninstall"] .blocklistedBox,
-richlistitem[opType="needs-uninstall"] .incompatibleBox,
-richlistitem[opType="needs-uninstall"] .needsDependenciesBox,
-richlistitem[opType="needs-uninstall"] .blocklistedBox {
-  display: none;
-}
-
 richlistitem[loading="true"] .updateBadge {
-  display: -moz-box;
   width: 16px;
   height: 16px;
   margin-bottom: -3px;
@@ -232,10 +196,6 @@ richlistitem[loading="true"] .updateBadge {
   border: none;
 }
 
-richlistitem[opType="needs-uninstall"] .notifyBadge {
-  display: none;
-}
-
 .addon-search-details {
   margin-top: 5px;
   margin-bottom: 5px;
@@ -265,17 +225,12 @@ richlistitem[opType="needs-uninstall"] .notifyBadge {
   -moz-image-region: rect(0px 48px 16px 32px);
 }
 
-.addonRating {
-  display: none;
-}
-
 .addonLearnMore {
   margin-top: 4px;
   margin-bottom: 4px;
 }
 
 .addonRating[rating] {
-  display: -moz-box;
   width: 59px;
   height: 11px;
   list-style-image: url("chrome://mozapps/skin/extensions/ratings.png");