wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 801437. Reimplement ensure_copy. r=ehsan

Browse Source 
The previous implementation would copy the entire file into memory which
would cause a huge amount of memory usage on when copying large files.
This version copies a block at a time to avoid this.
This commit is contained in:
Jeff Muizelaar 2012-11-08 16:57:49 -05:00
parent baccbd0090
commit 3062de063a
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
toolkit/mozapps/update/updater/updater.cpp
View File

@ -643,13 +643,16 @@ static int ensure_copy(const NS_tchar *path, const NS_tchar *dest)
return WRITE_ERROR;
}
void* buffer = malloc(ss.st_size);
// This block size was chosen pretty arbitrarily but seems like a reasonable
// compromise. For example, the optimal block size on a modern OS X machine
// is 100k */
const int blockSize = 32 * 1024;
void* buffer = malloc(blockSize);
if (!buffer)
return UPDATER_MEM_ERROR;
size_t left = ss.st_size;
while (left) {
size_t read = fread(buffer, 1, left, infile);
while (!feof(infile)) {
size_t read = fread(buffer, 1, blockSize, infile);
if (ferror(infile.get())) {
LOG(("ensure_copy: failed to read the file: " LOG_S ", err: %d",
path, errno));
@ -657,7 +660,6 @@ static int ensure_copy(const NS_tchar *path, const NS_tchar *dest)
return READ_ERROR;
}
left -= read;
size_t written = 0;
while (written < read) {