wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1109694 - Fix more bad implicit constructors in DOM; r=baku

Browse Source
This commit is contained in:
Ehsan Akhgari 2014-12-10 17:49:09 -05:00
parent 278b49e363
commit 3023408a90
20 changed files with 28 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docshell/shistory/src/nsSHEntryShared.cpp
View File

@ -34,7 +34,7 @@ uint64_t gSHEntrySharedID = 0;
typedef nsExpirationTracker<nsSHEntryShared, 3> HistoryTrackerBase;
class HistoryTracker MOZ_FINAL : public HistoryTrackerBase {
public:
HistoryTracker(uint32_t aTimeout)
explicit HistoryTracker(uint32_t aTimeout)
: HistoryTrackerBase(1000 * aTimeout / 2)
{
}

2
dom/canvas/CanvasRenderingContext2D.cpp
View File

@ -695,7 +695,7 @@ NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(CanvasPattern, mContext)
class CanvasDrawObserver
{
public:
CanvasDrawObserver(CanvasRenderingContext2D* aCanvasContext);
explicit CanvasDrawObserver(CanvasRenderingContext2D* aCanvasContext);
// Only enumerate draw calls that could affect the heuristic
enum DrawCallType {

4
dom/canvas/WebGLBindableName.h
View File

@ -54,9 +54,9 @@ class WebGLBindableName
{
public:
WebGLBindableName(GLuint name)
explicit WebGLBindableName(GLuint aName)
: WebGLBindable<T>()
, mGLName(name)
, mGLName(aName)
{ }
GLuint GLName() const { return mGLName; }

2
dom/geolocation/nsGeolocationSettings.h
View File

@ -57,7 +57,7 @@ enum GeolocationFuzzMethod {
class GeolocationSetting MOZ_FINAL {
public:
GeolocationSetting(const nsString& aOrigin) :
explicit GeolocationSetting(const nsString& aOrigin) :
mFuzzMethod(GEO_ALA_TYPE_DEFAULT),
#ifdef MOZ_APPROX_LOCATION
mDistance(0),

2
dom/html/nsBrowserElement.cpp
View File

@ -35,7 +35,7 @@ class nsBrowserElement::BrowserShownObserver : public nsIObserver
, public nsSupportsWeakReference
{
public:
BrowserShownObserver(nsBrowserElement* aBrowserElement);
explicit BrowserShownObserver(nsBrowserElement* aBrowserElement);
NS_DECL_ISUPPORTS
NS_DECL_NSIOBSERVER
void AddObserver();

2
dom/ipc/TabChild.cpp
View File

@ -758,7 +758,7 @@ class TabChild::DelayedDeleteRunnable MOZ_FINAL
nsRefPtr<TabChild> mTabChild;
public:
DelayedDeleteRunnable(TabChild* aTabChild)
explicit DelayedDeleteRunnable(TabChild* aTabChild)
: mTabChild(aTabChild)
{
MOZ_ASSERT(NS_IsMainThread());

3
dom/media/MediaDevices.h
View File

@ -24,7 +24,8 @@ struct MediaStreamConstraints;
class MediaDevices MOZ_FINAL : public DOMEventTargetHelper
{
public:
MediaDevices(nsPIDOMWindow* aWindow) : DOMEventTargetHelper(aWindow) {}
explicit MediaDevices(nsPIDOMWindow* aWindow) :
DOMEventTargetHelper(aWindow) {}
NS_DECL_ISUPPORTS_INHERITED
NS_DECLARE_STATIC_IID_ACCESSOR(MOZILLA_DOM_MEDIADEVICES_IMPLEMENTATION_IID)

4
dom/media/MediaPromise.h
View File

@ -57,7 +57,7 @@ public:
typedef RejectValueT RejectValueType;
NS_INLINE_DECL_THREADSAFE_REFCOUNTING(MediaPromise)
MediaPromise(const char* aCreationSite)
explicit MediaPromise(const char* aCreationSite)
: mCreationSite(aCreationSite)
, mMutex("MediaPromise Mutex")
{
@ -138,7 +138,7 @@ protected:
RejectValueType mRejectValue;
};
ThenValueBase(const char* aCallSite) : mCallSite(aCallSite)
explicit ThenValueBase(const char* aCallSite) : mCallSite(aCallSite)
{
MOZ_COUNT_CTOR(ThenValueBase);
}

6
dom/media/MediaStreamError.h
View File

@ -44,9 +44,9 @@ class MediaMgrError MOZ_FINAL : public nsISupports,
public BaseMediaMgrError
{
public:
MediaMgrError(const nsAString& aName,
const nsAString& aMessage = EmptyString(),
const nsAString& aConstraintName = EmptyString())
explicit MediaMgrError(const nsAString& aName,
const nsAString& aMessage = EmptyString(),
const nsAString& aConstraintName = EmptyString())
: BaseMediaMgrError(aName, aMessage, aConstraintName) {}
NS_DECL_THREADSAFE_ISUPPORTS

2
dom/media/MediaStreamGraph.h
View File

@ -1211,7 +1211,7 @@ public:
TrackRate GraphRate() const { return mSampleRate; }
protected:
MediaStreamGraph(TrackRate aSampleRate)
explicit MediaStreamGraph(TrackRate aSampleRate)
: mNextGraphUpdateIndex(1)
, mSampleRate(aSampleRate)
{

3
dom/media/MediaTaskQueue.h
View File

@ -92,7 +92,8 @@ private:
RefPtr<nsIRunnable> mRunnable;
bool mForceDispatch;
TaskQueueEntry(TemporaryRef<nsIRunnable> aRunnable, bool aForceDispatch = false)
explicit TaskQueueEntry(TemporaryRef<nsIRunnable> aRunnable,
bool aForceDispatch = false)
: mRunnable(aRunnable), mForceDispatch(aForceDispatch) {}
};

2
dom/media/fmp4/SharedDecoderManager.cpp
View File

@ -12,7 +12,7 @@ namespace mozilla {
class SharedDecoderCallback : public MediaDataDecoderCallback
{
public:
SharedDecoderCallback(SharedDecoderManager* aManager) : mManager(aManager) {}
explicit SharedDecoderCallback(SharedDecoderManager* aManager) : mManager(aManager) {}
virtual void Output(MediaData* aData) MOZ_OVERRIDE
{

6
dom/media/gmp-plugin/gmp-test-decryptor.cpp
View File

@ -150,9 +150,9 @@ public:
class SendMessageTask : public GMPTask {
public:
SendMessageTask(const string& aMessage,
TestManager* aTestManager = nullptr,
const string& aTestID = "")
explicit SendMessageTask(const string& aMessage,
TestManager* aTestManager = nullptr,
const string& aTestID = "")
: mMessage(aMessage), mTestmanager(aTestManager), mTestID(aTestID) {}
void Run() MOZ_OVERRIDE {

2
dom/media/gmp-plugin/gmp-test-decryptor.h
View File

@ -14,7 +14,7 @@
class FakeDecryptor : public GMPDecryptor {
public:
FakeDecryptor(GMPDecryptorHost* aHost);
explicit FakeDecryptor(GMPDecryptorHost* aHost);
virtual void Init(GMPDecryptorCallback* aCallback) MOZ_OVERRIDE {
mCallback = aCallback;

2
dom/media/gmp/GMPChild.cpp
View File

@ -361,7 +361,7 @@ GMPChild::PreLoadLibraries(const std::string& aPluginPath)
#if defined(XP_MACOSX)
class MacOSXSandboxStarter : public SandboxStarter {
public:
MacOSXSandboxStarter(GMPChild* aGMPChild)
explicit MacOSXSandboxStarter(GMPChild* aGMPChild)
: mGMPChild(aGMPChild)
{}
virtual void Start(const char* aLibPath) MOZ_OVERRIDE {

2
dom/media/gmp/GMPStorageChild.cpp
View File

@ -293,7 +293,7 @@ GMPStorageChild::EnumerateRecords(RecvGMPRecordIteratorPtr aRecvIteratorFunc,
class GMPRecordIteratorImpl : public GMPRecordIterator {
public:
GMPRecordIteratorImpl(const InfallibleTArray<nsCString>& aRecordNames)
explicit GMPRecordIteratorImpl(const InfallibleTArray<nsCString>& aRecordNames)
: mRecordNames(aRecordNames)
, mIndex(0)
{

2
dom/media/webm/SoftwareWebMVideoDecoder.h
View File

@ -24,7 +24,7 @@ public:
virtual void Shutdown() MOZ_OVERRIDE;
SoftwareWebMVideoDecoder(WebMReader* aReader);
explicit SoftwareWebMVideoDecoder(WebMReader* aReader);
~SoftwareWebMVideoDecoder();
private:

2
dom/plugins/ipc/PluginModuleChild.h
View File

@ -150,7 +150,7 @@ protected:
virtual bool AnswerGetProfile(nsCString* aProfile) MOZ_OVERRIDE;
public:
PluginModuleChild(bool aIsChrome);
explicit PluginModuleChild(bool aIsChrome);
virtual ~PluginModuleChild();
bool CommonInit(base::ProcessHandle aParentProcessHandle,

2
dom/vr/VRDevice.h
View File

@ -222,7 +222,7 @@ public:
virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE;
protected:
PositionSensorVRDevice(nsISupports* aParent)
explicit PositionSensorVRDevice(nsISupports* aParent)
: VRDevice(aParent, VRDevice::PositionSensor)
{ }

2
dom/workers/ServiceWorkerClients.h
View File

@ -28,7 +28,7 @@ public:
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(ServiceWorkerClients)
ServiceWorkerClients(ServiceWorkerGlobalScope* aWorkerScope);
explicit ServiceWorkerClients(ServiceWorkerGlobalScope* aWorkerScope);
already_AddRefed<Promise> GetServiced(ErrorResult& aRv);
already_AddRefed<Promise> ReloadAll(ErrorResult& aRv);