wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1219079 - Small breakdown-related fixes for the memory tool; r=jsantell

Browse Source 
* Add "Breakdown by" in front of dropdown selector for the selected breakdown.
* "Allocation Site" => "Allocation Stack" for breakdown's label.
* Make the coarse type breakdown bucket strings by count.
This commit is contained in:
Nick Fitzgerald 2015-10-28 10:59:25 -07:00
parent 49a186a23f
commit 2a9a3f16d3
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
devtools/client/memory/components/toolbar.js
View File

@ -36,10 +36,13 @@ const Toolbar = module.exports = createClass({
DOM.div({ className: "devtools-toolbar" }, [
DOM.button({ className: `take-snapshot devtools-button`, onClick: onTakeSnapshotClick }),
DOM.select({
className: `select-breakdown`,
onChange: e => onBreakdownChange(e.target.value),
}, breakdowns.map(({ name, displayName }) => DOM.option({ value: name }, displayName))),
DOM.label({},
"Breakdown by ",
DOM.select({
className: `select-breakdown`,
onChange: e => onBreakdownChange(e.target.value),
}, breakdowns.map(({ name, displayName }) => DOM.option({ value: name }, displayName)))
),
DOM.label({}, [
DOM.input({

4
devtools/client/memory/constants.js
View File

@ -49,14 +49,14 @@ const breakdowns = exports.breakdowns = {
breakdown: {
by: "coarseType",
objects: ALLOCATION_STACK,
strings: ALLOCATION_STACK,
strings: COUNT,
scripts: INTERNAL_TYPE,
other: INTERNAL_TYPE,
}
},
allocationStack: {
displayName: "Allocation Site",
displayName: "Allocation Stack",
breakdown: ALLOCATION_STACK,
},