From 29a9062ea2982e6b5a17da3b28312f673ca50b28 Mon Sep 17 00:00:00 2001 From: Alexander Surkov Date: Tue, 28 Jul 2009 10:26:32 +0800 Subject: [PATCH] Bug 504561 - Comboboxes do not emit accessibility events when selection changes, r=ginn.chen --- accessible/src/html/nsHTMLSelectAccessible.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/accessible/src/html/nsHTMLSelectAccessible.cpp b/accessible/src/html/nsHTMLSelectAccessible.cpp index 79d7b5b51cb..650efedaf9b 100644 --- a/accessible/src/html/nsHTMLSelectAccessible.cpp +++ b/accessible/src/html/nsHTMLSelectAccessible.cpp @@ -1023,19 +1023,20 @@ void nsHTMLComboboxAccessible::CacheChildren() if (!mListAccessible) { mListAccessible = new nsHTMLComboboxListAccessible(mParent, mDOMNode, mWeakShell); + if (!mListAccessible) + return; + + mListAccessible->Init(); } + #ifdef COMBO_BOX_WITH_THREE_CHILDREN buttonAccessible->SetNextSibling(mListAccessible); #else SetFirstChild(mListAccessible); #endif - if (!mListAccessible) { - return; - } mListAccessible->SetParent(this); mListAccessible->SetNextSibling(nsnull); - mListAccessible->Init(); ++ mAccChildCount; // List accessible child successfully added }