Bug 869836 - Part 12: Use Assign('c') instead of AssignLiteral("c"). r=ehsan

--HG--
extra : rebase_source : a6b15019cee452973dd8bf3112c15e14175855a9
This commit is contained in:
Birunthan Mohanathas 2014-05-26 21:55:08 +03:00
parent 65f503e85a
commit 2779282281
23 changed files with 43 additions and 43 deletions

View File

@ -915,24 +915,24 @@ nsWindowsShellService::SetDesktopBackground(nsIDOMElement* aElement,
nsAutoString style;
switch (aPosition) {
case BACKGROUND_TILE:
style.AssignLiteral("0");
tile.AssignLiteral("1");
style.Assign('0');
tile.Assign('1');
break;
case BACKGROUND_CENTER:
style.AssignLiteral("0");
tile.AssignLiteral("0");
style.Assign('0');
tile.Assign('0');
break;
case BACKGROUND_STRETCH:
style.AssignLiteral("2");
tile.AssignLiteral("0");
style.Assign('2');
tile.Assign('0');
break;
case BACKGROUND_FILL:
style.AssignLiteral("10");
tile.AssignLiteral("0");
tile.Assign('0');
break;
case BACKGROUND_FIT:
style.AssignLiteral("6");
tile.AssignLiteral("0");
style.Assign('6');
tile.Assign('0');
break;
}

View File

@ -992,7 +992,7 @@ WebSocket::ParseURL(const nsString& aURL)
nsAutoCString filePath;
rv = parsedURL->GetFilePath(filePath);
if (filePath.IsEmpty()) {
filePath.AssignLiteral("/");
filePath.Assign('/');
}
NS_ENSURE_SUCCESS(rv, NS_ERROR_DOM_SYNTAX_ERR);

View File

@ -1532,14 +1532,14 @@ nsObjectLoadingContent::UpdateObjectParameters(bool aJavaURI)
if (isJava && hasCodebase && codebaseStr.IsEmpty()) {
// Java treats codebase="" as "/"
codebaseStr.AssignLiteral("/");
codebaseStr.Assign('/');
// XXX(johns): This doesn't cover the case of "https:" which java would
// interpret as "https:///" but we interpret as this document's
// URI but with a changed scheme.
} else if (isJava && !hasCodebase) {
// Java expects a directory as the codebase, or else it will construct
// relative URIs incorrectly :(
codebaseStr.AssignLiteral(".");
codebaseStr.Assign('.');
}
if (!codebaseStr.IsEmpty()) {

View File

@ -98,10 +98,10 @@ nsXMLContentSerializer::Init(uint32_t aFlags, uint32_t aWrapColumn,
mLineBreak.AssignLiteral("\r\n");
}
else if (mFlags & nsIDocumentEncoder::OutputCRLineBreak) { // Mac
mLineBreak.AssignLiteral("\r");
mLineBreak.Assign('\r');
}
else if (mFlags & nsIDocumentEncoder::OutputLFLineBreak) { // Unix/DOM
mLineBreak.AssignLiteral("\n");
mLineBreak.Assign('\n');
}
else {
mLineBreak.AssignLiteral(NS_LINEBREAK); // Platform/default
@ -600,7 +600,7 @@ nsXMLContentSerializer::ConfirmPrefix(nsAString& aPrefix,
void
nsXMLContentSerializer::GenerateNewPrefix(nsAString& aPrefix)
{
aPrefix.AssignLiteral("a");
aPrefix.Assign('a');
char buf[128];
PR_snprintf(buf, sizeof(buf), "%d", mPrefixIndex++);
AppendASCIItoUTF16(buf, aPrefix);

View File

@ -4249,7 +4249,7 @@ XULDocument::BroadcasterHookup::~BroadcasterHookup()
}
else {
mObservesElement->GetAttr(kNameSpaceID_None, nsGkAtoms::observes, broadcasterID);
attribute.AssignLiteral("*");
attribute.Assign('*');
}
nsAutoCString attributeC,broadcasteridC;
@ -4398,7 +4398,7 @@ XULDocument::FindBroadcaster(Element* aElement,
*aListener = aElement;
NS_ADDREF(*aListener);
aAttribute.AssignLiteral("*");
aAttribute.Assign('*');
}
// Make sure we got a valid listener.

View File

@ -438,13 +438,13 @@ nsXULContentUtils::SetCommandUpdater(nsIDocument* aDocument, nsIContent* aElemen
nsAutoString events;
aElement->GetAttr(kNameSpaceID_None, nsGkAtoms::events, events);
if (events.IsEmpty())
events.AssignLiteral("*");
events.Assign('*');
nsAutoString targets;
aElement->GetAttr(kNameSpaceID_None, nsGkAtoms::targets, targets);
if (targets.IsEmpty())
targets.AssignLiteral("*");
targets.Assign('*');
nsCOMPtr<nsIDOMElement> domelement = do_QueryInterface(aElement);
NS_ASSERTION(domelement != nullptr, "not a DOM element");

View File

@ -251,7 +251,7 @@ nsXULTemplateQueryProcessorXML::CompileQuery(nsIXULTemplateBuilder* aBuilder,
// if an expression is not specified, then the default is to
// just take all of the children
if (expr.IsEmpty())
expr.AssignLiteral("*");
expr.Assign('*');
nsCOMPtr<nsIDOMXPathExpression> compiledexpr;
rv = CreateExpression(expr, aQueryNode, getter_AddRefs(compiledexpr));

View File

@ -4699,7 +4699,7 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI *aURI,
if (aURI) {
aURI->GetHostPort(hostport);
} else {
hostport.AssignLiteral("?");
hostport.Assign('?');
}
CopyUTF8toUTF16(hostport, formatStrs[formatStrCount++]);
}
@ -4725,7 +4725,7 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI *aURI,
rv = textToSubURI->UnEscapeURIForUI(charset, spec, formatStrs[formatStrCount]);
}
} else {
spec.AssignLiteral("?");
spec.Assign('?');
}
if (NS_FAILED(rv))
CopyUTF8toUTF16(spec, formatStrs[formatStrCount]);

View File

@ -107,7 +107,7 @@ BluetoothManager::BluetoothManager(nsPIDOMWindow *aWindow)
MOZ_ASSERT(aWindow);
MOZ_ASSERT(IsDOMBinding());
mPath.AssignLiteral("/");
mPath.Assign('/');
BluetoothService* bs = BluetoothService::Get();
NS_ENSURE_TRUE_VOID(bs);

View File

@ -107,7 +107,7 @@ BluetoothManager::BluetoothManager(nsPIDOMWindow *aWindow)
MOZ_ASSERT(aWindow);
MOZ_ASSERT(IsDOMBinding());
mPath.AssignLiteral("/");
mPath.Assign('/');
BluetoothService* bs = BluetoothService::Get();
NS_ENSURE_TRUE_VOID(bs);

View File

@ -315,7 +315,7 @@ DeviceStorageTypeChecker::Check(const nsAString& aType, nsIFile* aFile)
}
nsAutoString extensionMatch;
extensionMatch.AssignLiteral("*");
extensionMatch.Assign('*');
extensionMatch.Append(Substring(path, dotIdx));
extensionMatch.Append(';');
@ -358,7 +358,7 @@ DeviceStorageTypeChecker::GetTypeFromFileName(const nsAString& aFileName,
}
nsAutoString extensionMatch;
extensionMatch.AssignLiteral("*");
extensionMatch.Assign('*');
extensionMatch.Append(Substring(aFileName, dotIdx));
extensionMatch.Append(';');

View File

@ -3365,7 +3365,7 @@ WorkerPrivateParent<Derived>::SetBaseURI(nsIURI* aBaseURI)
nsCOMPtr<nsIURL> url(do_QueryInterface(aBaseURI));
if (url && NS_SUCCEEDED(url->GetQuery(temp)) && !temp.IsEmpty()) {
mLocationInfo.mSearch.AssignLiteral("?");
mLocationInfo.mSearch.Assign('?');
mLocationInfo.mSearch.Append(temp);
}
@ -3378,13 +3378,13 @@ WorkerPrivateParent<Derived>::SetBaseURI(nsIURI* aBaseURI)
if (NS_SUCCEEDED(aBaseURI->GetOriginCharset(charset)) &&
NS_SUCCEEDED(converter->UnEscapeURIForUI(charset, temp,
unicodeRef))) {
mLocationInfo.mHash.AssignLiteral("#");
mLocationInfo.mHash.Assign('#');
mLocationInfo.mHash.Append(NS_ConvertUTF16toUTF8(unicodeRef));
}
}
if (mLocationInfo.mHash.IsEmpty()) {
mLocationInfo.mHash.AssignLiteral("#");
mLocationInfo.mHash.Assign('#');
mLocationInfo.mHash.Append(temp);
}
}

View File

@ -481,7 +481,7 @@ txEXSLTFunctionCall::evaluate(txIEvalContext *aContext,
NS_ENSURE_SUCCESS(rv, rv);
}
else if (mType == SPLIT) {
pattern.AssignLiteral(" ");
pattern.Assign(' ');
}
else {
pattern.AssignLiteral("\t\r\n ");

View File

@ -324,7 +324,7 @@ txXSLTNumber::getCounters(Expr* aGroupSize, Expr* aGroupSeparator,
groupSeparator, defaultCounter);
NS_ENSURE_SUCCESS(rv, rv);
defaultCounter->mSeparator.AssignLiteral(".");
defaultCounter->mSeparator.Assign('.');
rv = aCounters.add(defaultCounter);
if (NS_FAILED(rv)) {
// XXX ErrorReport: out of memory
@ -343,7 +343,7 @@ txXSLTNumber::getCounters(Expr* aGroupSize, Expr* aGroupSeparator,
// there is only one formatting token and we're formatting a
// value-list longer then one we use the default separator. This
// won't be used when formatting the first value anyway.
sepToken.AssignLiteral(".");
sepToken.Assign('.');
}
else {
while (formatPos < formatLen &&

View File

@ -2303,7 +2303,7 @@ nsHTMLEditor::GetElementOrParentByTagName(const nsAString& aTagName,
bool getLink = IsLinkTag(tagName);
bool getNamedAnchor = IsNamedAnchorTag(tagName);
if (getLink || getNamedAnchor) {
tagName.AssignLiteral("a");
tagName.Assign('a');
}
bool findTableCell = tagName.EqualsLiteral("td");
bool findList = tagName.EqualsLiteral("list");
@ -2577,7 +2577,7 @@ nsHTMLEditor::CreateElementWithDefaults(const nsAString& aTagName)
nsAutoString realTagName;
if (IsLinkTag(tagName) || IsNamedAnchorTag(tagName)) {
realTagName.AssignLiteral("a");
realTagName.Assign('a');
} else {
realTagName = tagName;
}

View File

@ -708,9 +708,9 @@ nsHTMLEditor::SetResizingInfoPosition(int32_t aX, int32_t aY, int32_t aW, int32_
int32_t diffWidth = aW - mResizedObjectWidth;
int32_t diffHeight = aH - mResizedObjectHeight;
if (diffWidth > 0)
diffWidthStr.AssignLiteral("+");
diffWidthStr.Assign('+');
if (diffHeight > 0)
diffHeightStr.AssignLiteral("+");
diffHeightStr.Assign('+');
diffWidthStr.AppendInt(diffWidth);
diffHeightStr.AppendInt(diffHeight);

View File

@ -81,7 +81,7 @@ nsresult nsCollationUnix::Initialize(nsILocale* locale)
if (NS_SUCCEEDED(res)) {
// keep the same behavior as 4.x as well as avoiding Linux collation key problem
if (localeStr.LowerCaseEqualsLiteral("en_us")) { // note: locale is in platform format
localeStr.AssignLiteral("C");
localeStr.Assign('C');
}
nsPosixLocale::GetPlatformLocale(localeStr, mLocale);

View File

@ -310,7 +310,7 @@ void GeckoChildProcessHost::InitWindowsGroupID()
if (isSupported && NS_SUCCEEDED(taskbarInfo->GetDefaultGroupId(appId))) {
mGroupId.Append(appId);
} else {
mGroupId.AssignLiteral("-");
mGroupId.Assign('-');
}
}
}

View File

@ -35,7 +35,7 @@ GetFrameState(nsIFrame* aFrame)
nsFrameState state = aFrame->GetStateBits();
if (state == nsFrameState(0)) {
result.AssignLiteral("0");
result.Assign('0');
return result;
}

View File

@ -2292,7 +2292,7 @@ nsComputedDOMStyle::GetGridLineNames(const nsTArray<nsString>& aLineNames)
nsROCSSPrimitiveValue *val = new nsROCSSPrimitiveValue;
nsAutoString lineNamesString;
uint32_t i_end = aLineNames.Length();
lineNamesString.AssignLiteral("(");
lineNamesString.Assign('(');
if (i_end > 0) {
for (uint32_t i = 0;;) {
nsStyleUtil::AppendEscapedCSSIdent(aLineNames[i], lineNamesString);

View File

@ -1336,7 +1336,7 @@ nsParser::ParseFragment(const nsAString& aSourceBuffer,
if (theCount == 0) {
// Ensure that the buffer is not empty. Because none of the DTDs care
// about leading whitespace, this doesn't change the result.
theContext.AssignLiteral(" ");
theContext.Assign(' ');
}
// First, parse the context to build up the DTD's tag stack. Note that we

View File

@ -175,7 +175,7 @@ void nsColorPicker::ReadValueFromColorSelection(GtkColorSelection* colorselectio
GdkColor rgba;
gtk_color_selection_get_current_color(colorselection, &rgba);
mColor.AssignLiteral("#");
mColor.Assign('#');
mColor += ToHexString(convertGdkColorComponent(rgba.red));
mColor += ToHexString(convertGdkColorComponent(rgba.green));
mColor += ToHexString(convertGdkColorComponent(rgba.blue));

View File

@ -83,7 +83,7 @@ BGRIntToRGBString(DWORD color, nsAString& aResult)
BYTE g = GetGValue(color);
BYTE b = GetBValue(color);
aResult.AssignLiteral("#");
aResult.Assign('#');
aResult.Append(ToHexString(r));
aResult.Append(ToHexString(g));
aResult.Append(ToHexString(b));