From 26761c12a04296196810156c2066480cd701edbc Mon Sep 17 00:00:00 2001 From: Nathan Froyd Date: Mon, 29 Jun 2015 10:33:30 -0400 Subject: [PATCH] Bug 1178363 - make nsTimerImpl::PostTimerEvent a private method; r=poiru PostTimerEvent is only called by the timer thread, which is already able to access private members of nsTimerImpl; there's no reason for PostTimerEvent to be public. --- xpcom/threads/nsTimerImpl.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xpcom/threads/nsTimerImpl.h b/xpcom/threads/nsTimerImpl.h index e262eb5bb70..399db2d9395 100644 --- a/xpcom/threads/nsTimerImpl.h +++ b/xpcom/threads/nsTimerImpl.h @@ -45,9 +45,6 @@ public: friend struct TimerAdditionComparator; friend class nsTimerEvent; - // If a failure is encountered, the reference is returned to the caller - static already_AddRefed PostTimerEvent( - already_AddRefed aTimerRef); NS_DECL_THREADSAFE_ISUPPORTS NS_DECL_NSITIMER @@ -68,6 +65,10 @@ private: mozilla::tasktracer::TracedTaskCommon GetTracedTask(); #endif + // If a failure is encountered, the reference is returned to the caller + static already_AddRefed PostTimerEvent( + already_AddRefed aTimerRef); + enum class CallbackType : uint8_t { Unknown = 0, Interface = 1,