wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 576497 TabParent::AddProgressListener leaks new TabParentListenerInfo when mListenerInfoList.AppendElement(*info) succeeds

Browse Source 
r=smaug
This commit is contained in:
timeless@mozdev.org 2010-07-02 17:21:12 +03:00
parent 5a34e2465c
commit 25e98e98c8
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dom/ipc/TabParent.cpp
View File

@ -553,8 +553,7 @@ TabParent::AddProgressListener(nsIWebProgressListener* aListener,
{
nsresult rv;
TabParentListenerInfo* info = GetListenerInfo(aListener);
if (info) {
if (GetListenerInfo(aListener)) {
// The listener is already registered!
return NS_ERROR_FAILURE;
}
@ -564,16 +563,12 @@ TabParent::AddProgressListener(nsIWebProgressListener* aListener,
return NS_ERROR_INVALID_ARG;
}
info = new TabParentListenerInfo(listener, aNotifyMask);
if (!info) {
return NS_ERROR_OUT_OF_MEMORY;
}
TabParentListenerInfo info(listener, aNotifyMask);
rv = mListenerInfoList.AppendElement(*info) ? NS_OK : NS_ERROR_FAILURE;
if (NS_FAILED(rv)) {
delete info;
}
return rv;
if (!mListenerInfoList.AppendElement(info))
return NS_ERROR_FAILURE;
return NS_OK;
}
NS_IMETHODIMP