From 255e24f1f6993395237150518020bca64fea4969 Mon Sep 17 00:00:00 2001 From: Jordan Santell Date: Thu, 16 Jul 2015 15:40:23 -0700 Subject: [PATCH] Bug 1172408 - When checking if a marker details element has an action on click, pass in the marker details container so that we don't ascend up to the document, throwing an error. r=vp --- .../devtools/performance/modules/widgets/marker-details.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/devtools/performance/modules/widgets/marker-details.js b/browser/devtools/performance/modules/widgets/marker-details.js index 12780ea2a34..277546c3aa3 100644 --- a/browser/devtools/performance/modules/widgets/marker-details.js +++ b/browser/devtools/performance/modules/widgets/marker-details.js @@ -102,7 +102,7 @@ MarkerDetails.prototype = { * for the moment. */ _onClick: function (e) { - let data = findActionFromEvent(e.target); + let data = findActionFromEvent(e.target, this._parent); if (!data) { return; } @@ -121,7 +121,7 @@ MarkerDetails.prototype = { }; /** - * Take an element from an event `target`, and asend through + * Take an element from an event `target`, and ascend through * the DOM, looking for an element with a `data-action` attribute. Return * the parsed `data-action` value found, or null if none found before * reaching the parent `container`.