wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1059942 - Make dump_syms to parse public symbols. r=ted

Browse Source 
Currently, dump_syms does not look at public symbols if the object file
has debug info. This may cause it to skip some symbols that do not have
.debug_info section. Notably we see this at bionic routines implemented
in assembly. Details can be found at [1].

Apply patch [2] to enable dump_syms read public symbols even when
DWARF debug info is found.

[1] http://tinyurl.com/k3pxw5l

[2] https://breakpad.appspot.com/9684002/
This commit is contained in:
Wander Lairson Costa 2014-10-09 14:59:00 -04:00
parent 02a7c68ca8
commit 2319b77e7e
2 changed files with 56 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc
View File

@ -724,6 +724,8 @@ bool LoadSymbols(const string& obj_file,
names_end, elf_header->e_shnum);
if (gnu_debuglink_section) {
if (!info->debug_dirs().empty()) {
found_debug_info_section = true;
const char* debuglink_contents =
GetOffset<ElfClass, char>(elf_header,
gnu_debuglink_section->sh_offset);
@ -740,10 +742,10 @@ bool LoadSymbols(const string& obj_file,
fprintf(stderr, "%s does not contain a .gnu_debuglink section.\n",
obj_file.c_str());
}
} else {
}
}
if (symbol_data != ONLY_CFI) {
// The caller doesn't want to consult .gnu_debuglink.
// See if there are export symbols available.
const Shdr* dynsym_section =
FindElfSectionByName<ElfClass>(".dynsym", SHT_DYNSYM,
sections, names, names_end,
@ -773,24 +775,17 @@ bool LoadSymbols(const string& obj_file,
}
}
// Return true if some usable information was found, since
// the caller doesn't want to use .gnu_debuglink.
if (read_gnu_debug_link) {
return found_debug_info_section;
}
// Return true if some usable information was found
BPLOG(INFO) << "LoadSymbols: "
<< (found_usable_info ? "SUCCESS " : "FAILURE ")
<< obj_file;
return found_usable_info;
}
// No debug info was found, let the user try again with .gnu_debuglink
// if present.
BPLOG(INFO) << "LoadSymbols: FAILURE " << obj_file;
return false;
}
BPLOG(INFO) << "LoadSymbols: SUCCESS " << obj_file;
return true;
}
// Return the breakpad symbol file identifier for the architecture of
// ELF_HEADER.
template<typename ElfClass>

11
toolkit/crashreporter/google-breakpad/src/common/module.cc
View File

@ -105,12 +105,23 @@ void Module::AddStackFrameEntry(StackFrameEntry* stack_frame_entry) {
}
void Module::AddExtern(Extern *ext) {
Function func;
func.name = ext->name;
func.address = ext->address;
// Since parsing debug section and public info are not necessarily
// mutually exclusive, check if the symbol has already been read
// as a function to avoid duplicates.
if (functions_.find(&func) == functions_.end()) {
std::pair<ExternSet::iterator,bool> ret = externs_.insert(ext);
if (!ret.second) {
// Free the duplicate that was not inserted because this Module
// now owns it.
delete ext;
}
} else {
delete ext;
}
}
void Module::GetFunctions(vector<Function *> *vec,