wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 466751: setting .innerHTML to invalid markup in XHTML causes NS_ERROR_INVALID_POINTER, r+sr=jst

Browse Source
This commit is contained in:
Gavin Sharp 2009-01-16 14:19:27 -05:00
parent e0eefa9ffc
commit 21ff2ffc4c
3 changed files with 46 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
content/base/src/nsContentUtils.cpp
View File

@ -3586,7 +3586,6 @@ nsContentUtils::CreateContextualFragment(nsIDOMNode* aContextNode,
break;
}
// XXX Shouldn't we be returning rv if it's a failure code?
rv = parser->ParseFragment(aFragment, nsnull, tagStack,
!bHTML, contentType, mode);
if (NS_SUCCEEDED(rv)) {
@ -3595,7 +3594,7 @@ nsContentUtils::CreateContextualFragment(nsIDOMNode* aContextNode,
document->SetFragmentParser(parser);
return NS_OK;
return rv;
}
/* static */

1
content/base/test/Makefile.in
View File

@ -279,6 +279,7 @@ _TEST_FILES = test_bug5141.html \
file_XHRSendData.sjs \
file_XHRSendData_doc.xml \
file_XHRSendData_doc.xml^headers^ \
test_bug466751.xhtml \
$(NULL)
# Disabled for now. Mochitest isn't reliable enough for these.

44
content/base/test/test_bug466751.xhtml Normal file
View File

@ -0,0 +1,44 @@
<html xmlns="http://www.w3.org/1999/xhtml">
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=466751
-->
<head>
<title>Test for Bug 466751</title>
<script type="text/javascript" src="/MochiKit/packed.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=466751">Mozilla Bug 466751</a>
<p id="display"></p>
<div id="content" style="display: none">
<div id="test" />
</div>
<pre id="test">
<script class="testbody" type="text/javascript"><![CDATA[
/** Test for Bug 466751 **/
var el = $("test");
var result, message;
try {
el.innerHTML = '<div ">bla</div>';
} catch (ex) {
// ex.toString() == [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMNSHTMLElement.innerHTML]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: file:///Users/gavin/mobile/mozilla/content/base/test/test_bug466751.xhtml :: <TOP_LEVEL> :: line 30" data: no]
// ex.result == NS_ERROR_DOM_SYNTAX_ERR
// ex.message == Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMNSHTMLElement.innerHTML]
result = ex.result;
message = ex.message;
}
const NS_ERROR_DOM_SYNTAX_ERR = 0x8053000C;
ok(/An invalid or illegal string was specified/.test(message), "threw NS_ERROR_DOM_SYNTAX_ERR message");
is(result, NS_ERROR_DOM_SYNTAX_ERR, "threw NS_ERROR_DOM_SYNTAX_ERR result");
]]>
</script>
</pre>
</body>
</html>