wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1074258 - Expand entities at build time when copying strings.xml in Gradle. r=me

Browse Source 
DONTBUILD NPOTB

Android Studio (and IntelliJ) does not correctly handle &entity;
definitions in Android strings.xml files.  Strings with entities (in
Fennec, all of them) are rendered in the IDE as blank.  This patch
expands the entities when copying for use by Gradle, improving the IDE
integration.

MozReview-Commit-ID: 2T6CzoKc7v8
This commit is contained in:
Nick Alexander 2016-02-17 17:16:51 -08:00
parent 02e58071f5
commit 20ef13feb2
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mobile/android/app/build.gradle
View File

@ -233,9 +233,25 @@ task syncPreprocessedCode(type: Sync, dependsOn: rootProject.generateCodeAndReso
from("${topobjdir}/mobile/android/base/generated/preprocessed")
}
// The localization system uses the moz.build preprocessor to interpolate a .dtd
// file of XML entity definitions into an XML file of elements referencing those
// entities. (Each locale produces its own .dtd file, backstopped by the en-US
// .dtd file in tree.) Android Studio (and IntelliJ) don't handle these inline
// entities smoothly. This filter merely expands the entities in place, making
// them appear properly throughout the IDE.
class ExpandXMLEntitiesFilter extends FilterReader {
ExpandXMLEntitiesFilter(Reader input) {
// Extremely inefficient, but whatever.
super(new StringReader(groovy.xml.XmlUtil.serialize(new XmlParser(false, false, true).parse(input))))
}
}
task syncPreprocessedResources(type: Sync, dependsOn: rootProject.generateCodeAndResources) {
into("${project.buildDir}/generated/source/preprocessed_resources")
from("${topobjdir}/mobile/android/base/res")
filesMatching('**/strings.xml') {
filter(ExpandXMLEntitiesFilter)
}
}
// The omnijar inputs are listed as resource directory inputs to a dummy JAR.