wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1132953 - Zero AsmJSModule::CodeRange and AsmJSModule::ExportedFunction::pod on construction, to avoid Valgrind warnings. r=luke.

Browse Source
This commit is contained in:
Julian Seward 2015-02-27 10:24:07 +01:00
parent 714d70c1e7
commit 1f608d7457
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
js/src/asmjs/AsmJSModule.cpp
View File

@ -1304,6 +1304,7 @@ AsmJSModule::CodeRange::CodeRange(uint32_t nameIndex, uint32_t lineNumber,
profilingReturn_(l.profilingReturn.offset()),
end_(l.end.offset())
{
PodZero(&u); // zero padding for Valgrind
u.kind_ = Function;
setDeltas(l.entry.offset(), l.profilingJump.offset(), l.profilingEpilogue.offset());
@ -1328,9 +1329,13 @@ AsmJSModule::CodeRange::setDeltas(uint32_t entry, uint32_t profilingJump, uint32
}
AsmJSModule::CodeRange::CodeRange(Kind kind, uint32_t begin, uint32_t end)
: begin_(begin),
: nameIndex_(0),
lineNumber_(0),
begin_(begin),
profilingReturn_(0),
end_(end)
{
PodZero(&u); // zero padding for Valgrind
u.kind_ = kind;
MOZ_ASSERT(begin_ <= end_);
@ -1338,10 +1343,13 @@ AsmJSModule::CodeRange::CodeRange(Kind kind, uint32_t begin, uint32_t end)
}
AsmJSModule::CodeRange::CodeRange(Kind kind, uint32_t begin, uint32_t profilingReturn, uint32_t end)
: begin_(begin),
: nameIndex_(0),
lineNumber_(0),
begin_(begin),
profilingReturn_(profilingReturn),
end_(end)
{
PodZero(&u); // zero padding for Valgrind
u.kind_ = kind;
MOZ_ASSERT(begin_ < profilingReturn_);
@ -1351,10 +1359,13 @@ AsmJSModule::CodeRange::CodeRange(Kind kind, uint32_t begin, uint32_t profilingR
AsmJSModule::CodeRange::CodeRange(AsmJSExit::BuiltinKind builtin, uint32_t begin,
uint32_t profilingReturn, uint32_t end)
: begin_(begin),
: nameIndex_(0),
lineNumber_(0),
begin_(begin),
profilingReturn_(profilingReturn),
end_(end)
{
PodZero(&u); // zero padding for Valgrind
u.kind_ = Thunk;
u.thunk.target_ = builtin;

3
js/src/asmjs/AsmJSModule.h
View File

@ -453,6 +453,7 @@ class AsmJSModule
name_ = name;
maybeFieldName_ = maybeFieldName;
argCoercions_ = mozilla::Move(argCoercions);
mozilla::PodZero(&pod); // zero padding for Valgrind
pod.isChangeHeap_ = false;
pod.returnType_ = returnType;
pod.codeOffset_ = UINT32_MAX;
@ -468,6 +469,7 @@ class AsmJSModule
MOZ_ASSERT_IF(maybeFieldName, maybeFieldName->isTenured());
name_ = name;
maybeFieldName_ = maybeFieldName;
mozilla::PodZero(&pod); // zero padding for Valgrind
pod.isChangeHeap_ = true;
pod.startOffsetInModule_ = startOffsetInModule;
pod.endOffsetInModule_ = endOffsetInModule;
@ -485,6 +487,7 @@ class AsmJSModule
name_ = rhs.name_;
maybeFieldName_ = rhs.maybeFieldName_;
argCoercions_ = mozilla::Move(rhs.argCoercions_);
mozilla::PodZero(&pod); // zero padding for Valgrind
pod = rhs.pod;
}